Skip to content

Commit

Permalink
[ML] Single metric viewer functional test: add retry to reduce flakin…
Browse files Browse the repository at this point in the history
…ess (elastic#188686)

## Summary

Fixes elastic#188493

This PR unskips the single metric viewer functional test that is failing
(confirmed functionality is working as expected) and increases the
retries to reduce flakiness.

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6593


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
  • Loading branch information
alvarezmelissa87 authored Jul 19, 2024
1 parent d58de3d commit c830fbb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

for (const testData of testDataList) {
// FLAKY: https://github.com/elastic/kibana/issues/188493
describe.skip(testData.suiteSuffix, function () {
describe(testData.suiteSuffix, function () {
before(async () => {
await ml.api.createAndRunAnomalyDetectionLookbackJob(
testData.jobConfig,
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/functional/services/ml/single_metric_viewer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ export function MachineLearningSingleMetricViewerProvider(
},

async ensureAnomalyActionDiscoverButtonClicked() {
await retry.tryForTime(3 * 1000, async () => {
await retry.tryForTime(30 * 1000, async () => {
await testSubjects.click('mlAnomaliesListRowAction_viewInDiscoverButton');
await testSubjects.existOrFail('discoverLayoutResizableContainer');
await testSubjects.existOrFail('discoverLayoutResizableContainer', { timeout: 10 * 1000 });
});
},

Expand Down

0 comments on commit c830fbb

Please sign in to comment.