Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help finalising 1.0 and the future #1481

Closed
JedWatson opened this issue Jan 12, 2017 · 31 comments
Closed

Help finalising 1.0 and the future #1481

JedWatson opened this issue Jan 12, 2017 · 31 comments

Comments

@JedWatson
Copy link
Owner

Hi everyone! Happy New Year 🎉

Thanks for all the support with react-select. There's been a heap of really positive feedback, issues raised and PRs on the project, and it's getting an incredible amount of usage. With over 5,700 stars, 1,300 forks and more than 270k downloads per month on npm react-select has been way more popular than I could ever have expected. It's crazy and awesome.

As everyone watching the issue tracker can tell, the flip side to the popularity and broad usage is that as one of several open source projects I maintain I've ended up buried under a mountain of issues and PRs that I'd love to stay on top of but in the last few months haven't been able to.

But it's a new year, and time to get back on top of things, so I need some help 😄

Immediately, there are a heap of issues and PRs to triage - more than I could tackle in a week, full time.

So my plan is currently this:

  1. Get help identifying the PRs that fix immediate issues (not major changes or functional additions) or any critical issues without fixes that would block releasing 1.0.0 as stable.
  2. Merge those, ensure the demos and docs are up to date, and release.
  3. Add some maintainers to help with the ongoing triage and establish a regular release schedule
  4. Establish a roadmap for major improvements and new features we can work on this year

It would be really helpful if anyone tracking a PR that's ready to merge (and fixes issues, no major additions) could link to it with a brief explanation below. The same with any issues that I really need to deal with pre-1.0.0. I'll then organise these into a project so we can track progress.

Also, a few people have offered to help out as a maintainer - if that's you, I'd like to get a canonical list of who's currently interested (and has time) so please add your name in the comments.

Finally, if you're using the project somewhere cool, feel free to add that too. It's really nice to know.

Thanks!

@MarkLeMerise
Copy link

Hey, @JedWatson, I should be able to set some time aside to help. One common thread I've seen in issues is the need for reproducibility. At one point I was working on a CodePen and/or JSFiddle template for easy issue reproduction. Not sure if that's in the to-do list anywhere but I think it'd help many people!

@banderson
Copy link
Contributor

banderson commented Jan 12, 2017

@JedWatson reporting for duty 🙋‍♂️

I work with @TrevorBurnham who created HubSpot/react-select-plus to address blockers we had, but of course we'd rather help push the core project forward instead of diverging. Volunteering to contribute however we can!

@jooj123
Copy link
Contributor

jooj123 commented Jan 12, 2017

@JedWatson happy new year !
Add me to that list please

Chatted briefly to you at the react meetup - I work at domain group.
Happy to help where I can :)

@hoodwink73
Copy link

Hello @JedWatson et al.
I really appreciate react-select.

A project which extends input fields gets large in breadth by various user requirements and edge cases. I had seen the same happening to selectize-js.

Thank you for your efforts.

Here's is something which I am awaiting for in the stable version.

When a user writes anything inside a Creatable component but does not commit the value to the field and blurs away, the prompt text on the component fails to reset itself on the next focus.

react-select-prompt-text problem

The pull request #1306 already addresses this. You guys, @bvaughn and @JedWatson, have already taken a look at it.

There are also some outstanding issues related to this like #1256, which you can close if the pull request is merged.

Hope you guys have a great year ahead.

@vagnerj
Copy link

vagnerj commented Jan 19, 2017

Hello,
this PR #1331 is ready for merge and fixes missing focus() method for Select.Async, I suppose more devs would be happy :)

credits to the PR author!

@nraynaud
Copy link
Contributor

Hi,
this PR #1406 focuses the next item after a click instead of selecting the first of the list.
It's convenient for very long lists.

@banderson
Copy link
Contributor

@dave-clover I'm also interested in helping to push the testing initiative forward. Down to work together however we can to make this project more stable 👍

@agirton
Copy link
Collaborator

agirton commented Jan 25, 2017

Hi @JedWatson I use this component extensively and would love to join as a maintainer or really help where I can.

I agree with @dave-clover and @banderson that each PR should include a test. I'd be happy also to help with triaging bugs and hopefully get those down to a few pages 😄.

@balloob
Copy link

balloob commented Jan 27, 2017

Happy new year to you too! This project is awesome.

To reduce the flow of new issues, it would help to put out another RC on NPM so people would at least no longer report issues that have already been addressed.

@shinzui
Copy link

shinzui commented Jan 27, 2017

Is it possible to set some expectations? I am torn between forking and applying the needed patches, or waiting for you to start releasing fixes.

@robertmaloney
Copy link

Not sure where to put this, but I noticed that the Plunker bug reporting template didn't support ES6, so I ported it over to JSFiddle. You can fork it here: https://jsfiddle.net/3L1913xc/

@chriddyp
Copy link

chriddyp commented Feb 2, 2017

Finally, if you're using the project somewhere cool, feel free to add that too. It's really nice to know.

Huge thanks to all of the maintainers! We've been using react-select over at Plotly in our online chart creator (https://plot.ly/create). React-select has been an absolute godsend. We use the search, multi-select, and custom renders. Our users love the dropdown. Big thanks!

column-dropdown

@seanlindo
Copy link

seanlindo commented Feb 3, 2017

I'm very much interested in joining an open source project and contributing back. No hyperbole, I depend on this library heavily along with react-virtualized-select to help sourcers and recruiters do everything from tagging candidates to searching a list of 1,000+ industries.

Would love to help!

engagetalent.com

@dherran
Copy link

dherran commented Feb 15, 2017

As stated in the previous thread for the 1.0 pre-launch, I'd be happy to help out with bugfixes or reviews. I have a fork with a multi-select feature waiting to be merged and I use react-select in one major side project.

@MrLeebo
Copy link
Contributor

MrLeebo commented Mar 10, 2017

@JedWatson, thank you for contributing your time and energy into making this!

#773 is ready to merge. Fixes a bug where clearing a non-multi select control's selection by pressing Backspace causes the onChange event to pass [] instead of null.

I'd be happy to help get the Issue List under control by closing duplicates or "please debug my code for me"-type issues as a maintainer, also.

@beardedtim
Copy link

@JedWatson My team and I use this package for one of our projects and I would love to help the repo wherever I can.

@mcorteel
Copy link

@JedWatson The issues list is getting a little out of hand, is there a plan for the future?
There seems to be a huge community using your component (and waiting for a stable 1.0), should the community fork your work and continue maintaining it elsewhere or do you think that you will find time to maintain it in the near future?

Anyway, thanks a lot for this great component!

@julien-f
Copy link

If the list of issues is too big to triage, it may be useful to close the least recently updated ones with a message saying that the issue has been closed automatically but the users should feel free to comment on it if it's still relevant.

@bvaughn
Copy link
Collaborator

bvaughn commented Mar 29, 2017

@mcorteel Would you be interested in contributing? If so, I bet Jed would love to get your help with some of these issues and PRs!

@mcorteel
Copy link

Why not, at least I can help triage issues.

@Stenerson
Copy link
Contributor

@JedWatson #1436 is ready to merge (even contains doc and a test 😱)

It adds an option to @bvaughn's excellent Creatable component that will optionally place the "Add" row on the bottom of the list rather than the top. This is particularly important when you don't want to encourage your users to add a new item but you want the option to be available in case they need it. Having the creatable item show up at the end of the list greatly reduces my users from adding new items accidentally.

Thanks - and count me in for helping triage, answer questions and contribute additional PRs in the future. I ❤️ react-select!

P.S. Merging #1436 will also allow you to close #1416

@broncha
Copy link

broncha commented Jun 21, 2017

@JedWatson This tiny fix #1805 can also go in the next release :)

@marlonmleite
Copy link

marlonmleite commented Aug 30, 2017

Is this repository abandoned?
Since May we have no release. I am impressed as something so good, it has many bugs and several PR and ISSUES opened.
We have a lot of problems in this lib here in the company and we are starting to hate him lol

@JedWatson any?

@agirton
Copy link
Collaborator

agirton commented Aug 30, 2017

@marlonmleite this project has not been abandoned. We've just been busy with our full time responsibilities outside of open source.

@agirton agirton closed this as completed Aug 30, 2017
@agirton agirton reopened this Aug 30, 2017
@marlonmleite
Copy link

@agirton Do you need help? Depending I can contribute. I see many open PR and many issues with critical errors.
Is there a new release forecast?

@bvaughn
Copy link
Collaborator

bvaughn commented Aug 30, 2017

We have a lot of problems in this lib here in the company and we are starting to hate him lol

Probably just poorly chosen words, but... 😄 react-select is MIT licensed, meaning that you are free to fork it at any point if a [for-profit] business is using it and isn't happy with the response time of [volunteer, unpaid] contributors.

I realize there's a time investment in ramping up on a new project like this, but on the other hand, worst case is you've gotten a great head start essentially for free from the community.

@JedWatson
Copy link
Owner Author

I'm very happy to announce that 1.0 is out of beta, finally - with massive thanks to some major contributors including @gwyneplaine, @Noviny, @bvaughn and @agirton for their help.

@bvaughn
Copy link
Collaborator

bvaughn commented Nov 24, 2017

Partaaaaay 🎊 🎈 Great work Jed!

@agirton
Copy link
Collaborator

agirton commented Nov 24, 2017

Woohoo 🎉🍾! Great work @JedWatson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests