Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping of values when used in width constrained parent #1805

Closed
broncha opened this issue Jun 21, 2017 · 1 comment
Closed

Wrapping of values when used in width constrained parent #1805

broncha opened this issue Jun 21, 2017 · 1 comment

Comments

@broncha
Copy link

broncha commented Jun 21, 2017

Hi,

I recently had to use this where the parent had a max-width constraint, and when the labels are long, they are wrapped and interferes with the close icon.

This is how it looks
screen shot 2017-06-21 at 12 23 49 pm

This can easily fixed by having .Select--multi .Select-value to be inline-flex instead of inline-block.

This is the result

screen shot 2017-06-21 at 12 25 09 pm

Its a tiny fix. If you want a PR for this I can create one. Thanks for the awesome component!
Cheers

@agirton
Copy link
Collaborator

agirton commented Jun 21, 2017

Hi @broncha the only issue I see with using inline-flex is some people have to support browsers that don't support this feature. Since this can be handled on your end, I would rather not introduce something new that may break other users.

@broncha broncha closed this as completed Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants