Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When first option is disabled it does not appear when the pulldown is first opened #1294

Closed
boriswexler opened this issue Oct 10, 2016 · 8 comments

Comments

@boriswexler
Copy link

If the first option is disabled, the pulldown will start scrolled down at the second option - meaning the user will not see the first (disabled option) unless they think of scrolling up.

@enf0rc3
Copy link

enf0rc3 commented Jan 16, 2017

https://github.com/JedWatson/react-select/blob/master/src/Select.js#L212

Is where the issue is, The offset doesn't take into account disabled options.

enf0rc3 added a commit to enf0rc3/react-select that referenced this issue Jan 17, 2017
…o the previous option if it is disabled, it will show the disabled option even if it isn't focused.

JedWatson#1294
@boriswexler
Copy link
Author

awesome thanks! Would you create a PR with your change and list it here? Thanks again!

@jooseptame
Copy link

+1

@florentdestremau
Copy link

Is there a current workaround ? I'm experiencing this right now 😕

@brentoneill
Copy link

+1

@brentoneill
Copy link

@enf0rc3 - tried applying that commit to my local react-select and it broke the component. Are there additional commits or a branch I can look at?

@mtlewis
Copy link
Contributor

mtlewis commented Nov 27, 2017

This should be fixed by #2170 (merged to master, not yet published).

@bladey
Copy link
Contributor

bladey commented May 27, 2020

Hello -

In an effort to sustain the react-select project going forward, we're closing old issues / pull requests.

We understand this might be inconvenient but in the best interest of supporting the broader community we have to direct our limited efforts to maintain the latest version.

If you feel this issue / pull request is still relevant and you'd like us to review it, please leave a comment and we'll do our best to get back to you.

@bladey bladey closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants