-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to show new creatable item as first or last option #1436
Conversation
Seems to be a duplicate of #1416 |
Ahh, you're right @RKushnir! 😞 But this one includes a passing test and doesn't include the build files as specified in CONTRIBUTING.md 😉 |
If I apply your pull request I get the create item at the last position but if I try to switch options with the up and down keys I cannot select this last option. If I do the same on the master branch I can select the first option with the keyboard. Also if I move with the mouse over the last option it gets not highlighted, instead the first option gets highlighted. That hints to me that somewhere else in the code it is assumed that the first option is the create item. How can we fix this? |
Hi @blacktemplar, |
FYI - that commit was just rebasing and fixing a conflict that was introduced to the README file |
I just rechecked my code and I think it was my mistake after merging everything with the newest version here I got it working. |
Are there plans to merge this in anytime soon? |
I'd love to use this feature but I can't get it to work. Using Virtualized Select on top of it,
The prop promptTextCreator is also a Creatable prop and it works just fine. See anything wrong? |
It is counter-intuitive to show the 'create option' at the start, to the user when it is already available in the list below. Hence, +1 support for this feature. |
@Stenerson I think this is a big UX win. Thank you for the tests also! I'm not sure yet if this should go in 1.0 RC or should wait till after. I'm leaning towards waiting till after 1.0 is released. |
Any chance this will be pushed soon? |
@AaronHarris this will be pulled in after 1.0 release. Will be working with Jed to confirm when that is. |
+1 support for this feature |
looking forward to this |
Is there an update on this? |
When v1.0.0 ships I'll resolve the remaining conflicts with master and it will be available to merge into 1.1.0. 🤞 |
@JedWatson, any idea when we can start merging "After 1.0 release items"? My users are still struggling a bit with this, adding a bunch of unwanted items because they're used to typing part of a selection and pressing enter. Moving this to the bottom will be a big help. Thanks! 🙏 |
Please merge this as soon as possible, really need to use this option. 👍 |
Also really looking forward to this one! It will make a huge difference for us. |
@JedWatson, this is an easy win with quite a bit of support. Any thoughts on getting it merged and released soon? I'm loving all of the effort and excitement around v2 but 10s of thousands of us are still relying on v1 and will be for the foreseeable future. This PR has been ✅with passing tests for over 14 months now. I seriously respect you for the time and mental burden that a project this popular must take to maintain. I'm definitely not saying this to be negative. I just want to see react-select continue to move forward and part of that is improving the version that people are using in production. 🙏 Thank you for your consideration and your continued effort and dedication to this incredibly important component. 🙏 |
@Stenerson I love you. TY @jossmac for merging this. I'm planning to migrate to V2 but it it not a top priority right now and the previous behaviour is a bad UX IMO. |
BTW, any chances of updating the https://v1.react-select.com/ to reflect this changes ? |
With this change, the new Creatable option will:
false
)