Fixed add group button changing color after adding 10 groups #8392
Conversation
…er changed the text color from white to background color. Changed the method setNewGroupButtonStyle of class GroupTreeView. fixes JabRef#8051
|
Based on your screenshots, issue #8051 does not seem solved by the current state of your PR: the |
…utton in GroupTree.css. Deleted method setNewGroupButtonStyle brcause the button is unstylized. fixes JabRef#8051
…utton in GroupTree.css. Deleted method setNewGroupButtonStyle as the button is unstylized. fixes JabRef#8051
|
I made some commits. Please check if the color of the button is better now. Thanks! |
|
Thank you @dimitrisdimos00 for tackling this issue. |
|
Here: |
|
@dimitrisdimos00 This looks great! |
|
@mlep Your welcome! Glad to help! |
Siedlerchr
added
the
status: ready-for-review
|
In my opinion, in light mode, the darkish blue colour (or at least some kind of different colour) is needed as a contrast to |
|
I don't really know how to proceed with this PR. We also probably could use something like our ADRs we have for decisions about code architecture but for our UI design decisions? |
|
I never really got the idea of those after 10 groups it's showing in a different color |
|
Well personally I find it kind of strange as a functionality. If we want the user to learn this button maybe we could do it through a tutorial rather than this. |
|
I remember I got the idea from feedly (In http://blog.feedly.com/wp-content/uploads/2017/10/discover.gif the "Add content" button has a green background until you added a few sources). Given that their interface is quite usable, I trusted that they have competent ui experts and did their research whether this feature is helpful or not (we sadly don't have the resources for a proper A/B testing etc). But I do agree that it's not very standard behavior to change the background color like this. |
|
I guess it's not such a bad feature. If we keep it though it would be better to change it to a different, more visible and more matching color than before... |
|
DIN 66234, Teil 8: "Erwartungskonformität". - I would translate it to "expectation conformance" - An application should behave as expected by the user. The difficult thing is to guess the expectations. Since this is the only place in JabRef with that functionality - and that functionality does not seem to be common. However, if this functionality is used consistently within JabRef, it is maybe cool. Maybe, this is also a call for an "basic" and "advanced" mode of JabRef. #futurework Thus, we remove this functionality for now. |
koppor
removed
the
status: ready-for-review
* upstream/main: (50 commits) New Crowdin updates (#8451) Fix library tab exception when saving prefs (#8450) Rename Groups interface into Groups (#8449) New Crowdin updates (#8445) update snap url Update bug_report.yml for 5.5 Show development information\n\n+semver: minor Release v5.5 Update journal abbrev list New Crowdin updates (#8439) Refresh example styles Squashed 'buildres/csl/csl-styles/' changes from 5563ccc..0237ae7 Fixed add group button changing color after adding 10 groups (#8392) Bump slf4j-api from 2.0.0-alpha5 to 2.0.0-alpha6 in /buildSrc (#8438) Bump libreoffice from 7.2.3 to 7.2.5 (#8436) Bump org.openjfx.javafxplugin from 0.0.10 to 0.0.11 (#8437) Fix file directory preferences not respected (#8429) Refresh example styles Squashed 'buildres/csl/csl-locales/' changes from c38205618f..4a551a87c3 Refresh example styles ...
Moreover changed the text color from white to background color. Changed the method setNewGroupButtonStyle of class GroupTreeView. Also changed the GroupTree.css file. Deleted the inactive pseudoclass as it will not be used.
fixes #8051
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)In these pictures we see the new button not changing after having 10+ groups: