UI: Dark theme: "Add group" button seems inactivated

[mlep]

JabRef version

Latest development branch build (please note build date below)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.4--2021-09-01--69550d3 Linux 4.19.0-17-amd64 amd64 Java 16.0.2 JavaFX 16+8

Checked with the latest development build

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behavior

In dark theme:

• At the bottom of the group interface, the button Add group is, at first, very visible (too much I would say):
  

• Then (after some time, or after creating a subgroup?), the appearance of this button is modified, and it looks like it is inactivated (black characters on grey background):
  

I would expect the Add group button to look like the Search button.

Appendix

...

Log File

``` Paste an excerpt of your log file here ```

[berry120]

I thought I might have a look at this one, but I can't actually reproduce it - I've tried waiting a while then creating a subgroup, or just creating a whole bunch of groups - but I never get the issue where the button is disabled.

Has anyone else had any joy in reproducing this and if so, are there any specific steps? Thanks!

[mlep]

@berry120 The button is not really disabled. It just looks like it is disable.
And I do not know which criteria makes the button appearance change. It is coded somewhere. If I recall correctly, the very visible button was designed to attract attention to new users.

[berry120]

@mlep I also haven't been able to reproduce the behaviour where the button looks disabled while it's not I'm afraid - though I'm only on Windows, so it's possible it's a platform specific thing maybe?

[mlep]

@berry120: I found the information that should allow you to see a different button: the button should change appearance after creating 10 groups (#7714)

The disabled (bad) look maybe Linux-specific.
Maybe windows beneficiate of a better look (but I cannot test on windows).

[srshiao]

I was able to reproduce this behavior on Windows, but am I understanding that this is an intended feature or is there still a fix that needs to be made here?

[mlep]

It is intended that the button change in appearance.
What is not intended it that, afterwards, the button looks deactivated.
The "Add group" button should look like the "Search" button located at the bottom of the screenshot.

[srshiao]

Got it, I can try to do that!

[dimitrisdimos00]

Hello! Is this issue fixed? I think I have managed to tackle it, if @srshiao hasn't already. Take a look.

I don't know though if this functionality (e.g. the button to change color after inserting 10 groups) is necessary. You have the last word however.

[mlep]

It seems that @srshiao has lost interest. So, you are free to propose a PR.

Personally, I find the change in color after 10 inserted groups more disturbing than useful (and, to my knowledge, this is an oddity in JabRef since it occurs only for this feature). @Siedlerchr : What do you think?

[Siedlerchr]

Yes, I agree with you @mlep

[tobiasdiez]

The idea was that new users learn to find the "new group" button, and once they know where it is the visual highlight is no longer necessary. I cannot found the PR where this was added, but there was some discussion about this already.

[Siedlerchr]

@dimitrisdimos00 Thanks again for your contribution! Included in the newest Bugfix release as well.

[dimitrisdimos00]

Happy to help!