Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix library tab exception when saving prefs #8450

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Fix library tab exception when saving prefs #8450

merged 3 commits into from
Jan 19, 2022

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jan 19, 2022

Fixes #7614

Could not test it but I think the underlying issue is the same as described in #7470

When loading/opening a bib file a new "normal" Tab is inserted to indicate loading. That is later removed again and it's not an instanceof our LibraryTab

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 19, 2022
@Siedlerchr
Copy link
Member Author

ooops, wrong formatting command..

@Siedlerchr Siedlerchr merged commit 9024f87 into main Jan 19, 2022
@Siedlerchr Siedlerchr deleted the fixLibraryTab branch January 19, 2022 18:16
Siedlerchr added a commit that referenced this pull request Jan 21, 2022
* upstream/main: (50 commits)
  New Crowdin updates (#8451)
  Fix library tab exception when saving prefs (#8450)
  Rename Groups interface into Groups (#8449)
  New Crowdin updates (#8445)
  update snap url
  Update bug_report.yml for 5.5
  Show development information\n\n+semver: minor
  Release v5.5
  Update journal abbrev list
  New Crowdin updates (#8439)
  Refresh example styles
  Squashed 'buildres/csl/csl-styles/' changes from 5563ccc..0237ae7
  Fixed add group button changing color after adding 10 groups (#8392)
  Bump slf4j-api from 2.0.0-alpha5 to 2.0.0-alpha6 in /buildSrc (#8438)
  Bump libreoffice from 7.2.3 to 7.2.5 (#8436)
  Bump org.openjfx.javafxplugin from 0.0.10 to 0.0.11 (#8437)
  Fix file directory preferences not respected (#8429)
  Refresh example styles
  Squashed 'buildres/csl/csl-locales/' changes from c38205618f..4a551a87c3
  Refresh example styles
  ...
Siedlerchr added a commit that referenced this pull request Jan 28, 2022
* upstream/main: (24 commits)
  Support CrossRef in CSL styles (#8454)
  Update FUNDING.yml (#8473)
  Update to Javafx 17.02 (#8470)
  Made search button in Web search wider. Also skewed side panel titles to the left (#8463)
  Bump h2-mvstore from 2.0.206 to 2.1.210 in /buildSrc (#8458)
  Bump mariadb-java-client from 2.7.4 to 2.7.5 (#8457)
  Bump com.github.andygoossens.modernizer from 1.6.1 to 1.6.2 (#8459)
  Bump mockito-core from 4.2.0 to 4.3.0 (#8460)
  Bump xmlunit-matchers from 2.8.3 to 2.8.4 (#8461)
  Improve error handling for browser extension (#8432)
  New Crowdin updates (#8451)
  Fix library tab exception when saving prefs (#8450)
  Rename Groups interface into Groups (#8449)
  New Crowdin updates (#8445)
  update snap url
  Update bug_report.yml for 5.5
  Show development information\n\n+semver: minor
  Release v5.5
  Update journal abbrev list
  New Crowdin updates (#8439)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different problems when (trying) to open a library
2 participants