fix suggestion provider for crossref field

[LoayGhreeb]

Context: #10910 (comment), #10910 (comment)
Related issue: #8145

Mandatory checks

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[LoayGhreeb]

Should I remove the ItemProducer and the StringConverter since I added the requested string to the beginning of the suggestion list in getSuggestions method?

https://github.com/LoayGhreeb/jabref/blob/3b6835372b374d736c7f64cf3ea9fae193ba10cd/src/main/java/org/jabref/gui/fieldeditors/LinkedEntriesEditor.java#L64-L65

[Siedlerchr]

Shouldn't we first have the settings for this?

[LoayGhreeb]

Shouldn't we first have the settings for this?

@Siedlerchr If someone wants to enable autocomplete only for the crossref field, they can achieve it by enabling autocomplete in the preferences and selecting only crossref in the "Affected fields".

[koppor]

Should I remove the ItemProducer and the StringConverter since I added the requested string to the beginning of the suggestion list in getSuggestions method?

I don't understand this question, but sounds good.

[koppor]

Regarding the autocompletion for cross ref.

This was feature #8145

Either

• Undo the change regarding this property
• Add fine grained auto completion configuration

Regarding the second option, our preferences currently look as follows:

Proposal:

• Use autcompletion
  • auto-complete links to other entries
  • auto-complete person names
  • auto-complete other fiels: {fields}

The crossed items are the default setting. For {fields}, the default is keywords, journal, publisher, title.

I don't know about performance difference between cross-ref only and fields having FieldProperty.MULTIPLE_ENTRY_LINK, FieldProperty.SINGLE_ENTRY_LINK

If there is a difference, then as follows

• auto-complete cross-ref fields
• auto-complete fields with links to other entries

[LoayGhreeb]

I don't understand this question, but sounds good.

@koppor It's the same question that I asked here: #10910 (comment).

[LoayGhreeb]

This was feature #8145

I read the conversation for this issue, and I think this feature wasn't requested for this issue. The problem described is that the crossref field doesn't work when autocomplete is disabled, it doesn't request that the suggestion provider for crossref should work when autocomplete is disabled.

[koppor]

I think, this is good to go.

Small comment:

Why is the list entry red even if the typed-in citation key exists?

[Siedlerchr]

Thanks again for the good work!