Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Crossref" field should also work if Autocomplete is disabled #8145

Closed
2 tasks done
nicolahinssen opened this issue Oct 13, 2021 · 8 comments · Fixed by #10829
Closed
2 tasks done

"Crossref" field should also work if Autocomplete is disabled #8145

nicolahinssen opened this issue Oct 13, 2021 · 8 comments · Fixed by #10829
Labels
autocompletion entry-preview preferences type: enhancement

Comments

@nicolahinssen
Copy link

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

Windows 11 Pro (build 22471) | JabRef 5.4--2021-10-11--2e71d5f

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Enter a citekey (in my case an "mvBook") of the parent entry in the crossref field
  2. The BibLaTeX source doesn't show the crossref line.
  3. After closing JabRef and reopening, the crossref input field is also empty again.

Appendix

...

Log File `It seems nothing is being logged `
@Siedlerchr
Copy link
Member

You need to have Autcompletion enable for crossref: I guess this is disabled
In the preferences -> Entry Editor -> Use autcompletion
grafik

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Oct 13, 2021
@nicolahinssen
Copy link
Author

nicolahinssen commented Oct 14, 2021 •
edited
Loading

Thank you for you quick reply. Autocomplete solved the problem, just like you said!

However, I think it's weird that the crossref feature doesn't work out of the box. Furthermore it would be nice if the preview layout was also updated according to the merged parent/child entries.

@Siedlerchr Siedlerchr removed the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Oct 14, 2021
@Siedlerchr Siedlerchr changed the title "Crossref" field is not applied "Crossref" field is not applied when Autcomplete is disabled Oct 14, 2021
@Siedlerchr Siedlerchr changed the title "Crossref" field is not applied when Autcomplete is disabled "Crossref" field should also work if Autcomplete is disabled Oct 16, 2021
@Siedlerchr
Copy link
Member

I changed the title and marked it as feature. Regarding the entry preview see #7378

@Siedlerchr Siedlerchr changed the title "Crossref" field should also work if Autcomplete is disabled "Crossref" field should also work if Autocomplete is disabled Oct 16, 2021
@ThiloteE
Copy link
Member

ThiloteE commented May 12, 2022 •
edited
Loading

I would suggest a separate preference to enable crossref because of severe performance issues of autocompletion when it comes to large databases. See #6967. And of course, it should work if autocomplete is enabled.

@Siedlerchr
Copy link
Member

For anyone wanting so solve this, have a look at FieldEditors in combination with SuggestionProviders

@pal-anish
Copy link
Contributor

Hi @Siedlerchr
I need some brainstorming about this issue. I am requesting some suggestions for it.

@Siedlerchr
Copy link
Member

StandardField.Crossref has a Field property called SINGLE_ENTRY_LINK, in FieldEditors the getSuggestionProvider is called and the value (the thing which handles the autocomplete) is then passed down to the field type editor
If you follow the trail where the suggestion Provider originally comes from
FieldsEditor > FieldsEditorTab > Entry Editor -> LIbraryTab -> setupAutocomplete

Inside SuggestionProvider class there is this isEmpty check.
Here you would need to add a check for the SingleLink or MultipleLink property or CrossRef field
I would suggest just checking the field type to allow all possible link fields to work.

Autocompletion is controlled by AutocompletePreferences

pal-anish pushed a commit to pal-anish/jabref that referenced this issue Jan 29, 2024
JabRef#8145 Fix Suggestion Provider for Crossref during autocompletio…
d2d8492 
…n disable
@pal-anish pal-anish mentioned this issue Jan 29, 2024
Merged
6 tasks
pal-anish pushed a commit to pal-anish/jabref that referenced this issue Jan 29, 2024
JabRef#8145 Fix Test Cases Related Issue
5436e69
@pal-anish
Copy link
Contributor

@Siedlerchr Can you please review my changes? I have created a PR to resolve this issue.

pal-anish pushed a commit to pal-anish/jabref that referenced this issue Jan 30, 2024
JabRef#8145 Removed unwanted commented code
0c417fb
pal-anish pushed a commit to pal-anish/jabref that referenced this issue Jan 30, 2024
JabRef#8145 Added Changelog.md file
c5fd61f
github-merge-queue bot pushed a commit that referenced this issue Feb 1, 2024
@pal-anish
Fix Suggestion Provider for Crossref during autocompletion disable (#…
4bd3771 
…10829)

* #8145 Fix Suggestion Provider for Crossref during autocompletion disable

* #8145 Fix Test Cases Related Issue

* #8145 Removed unwanted commented code

* #8145 Added Changelog.md file

---------

Co-authored-by: Anish.Pal <[email protected]>
@Siedlerchr Siedlerchr mentioned this issue Feb 27, 2024
Merged
6 tasks
LoayGhreeb added a commit to LoayGhreeb/jabref that referenced this issue Mar 1, 2024
@LoayGhreeb
Fix Suggestion Provider [JabRef#8145]
ba7487d
@LoayGhreeb LoayGhreeb mentioned this issue Mar 2, 2024
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 5, 2024
@LoayGhreeb @koppor
Implemented TagsField for the Keywords field (#10910)
8374693 
* added selection box next to the keyword field

* added selection box next to the keyword field

* Update CHANGELOG.md

* Rewrite keywords field: used tags field

* Update src/main/java/org/jabref/gui/fieldeditors/KeywordsEditorViewModel.java

Co-authored-by: Oliver Kopp <[email protected]>

* Fix Suggestion Provider [#8145]

* Add context menu for keywordsEditor

* Fixed OpenRewrite test issue

* Add typed text as first suggestion

* Revert "Fix Suggestion Provider"

* Remove unused imports

* Bind the keywords and tags field

* Update CHANGELOG.md

* Remove duplicates from the suggestions list

* use Labels as a tag view

* Add LOGGER.debug

* remove chip-view from CSS file

* Update CHANGELOG.md

---------

Co-authored-by: Oliver Kopp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
autocompletion entry-preview preferences type: enhancement
Projects
Features & Enhancements
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Suggestion Provider for Crossref during autocompletion disable pal-anish/jabref
4 participants
@Siedlerchr @nicolahinssen @pal-anish @ThiloteE