Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-cli: feeding ledger peers into genesis create-staked #4123

Closed
deepfire opened this issue Jul 1, 2022 · 2 comments · Fixed by #4234
Closed

cardano-cli: feeding ledger peers into genesis create-staked #4123

deepfire opened this issue Jul 1, 2022 · 2 comments · Fixed by #4234
Assignees
Labels
peer2peer Issues / PRs related to peer-2-peer

Comments

@deepfire
Copy link
Contributor

deepfire commented Jul 1, 2022

genesis create-staked needs to be extended with ability to inject stake pool -> IP/DNS address associations -- aka "ledger peers".

Suggested format interface: --ledger-peers PEERS-JSON-FILE, with the following structure:

{ public_key_1: ["ipaddr1", "ipaddr2", ...]
, public_key_2: ["dnsaddr3"]
, ...
}

It's not unlikely that this might need consensus integration as well.

Now -- where this information should go?

@deepfire
Copy link
Contributor Author

Suggested addition of DNS names support.

@deepfire
Copy link
Contributor Author

Added the wherewithals of ledger peer placement.

@deepfire deepfire moved this from Needs Discussion to In Progress in Performance & Tracing Aug 2, 2022
iohk-bors bot added a commit that referenced this issue Aug 11, 2022
4234: Update create-staked with the ability to specify relays for all created stake pools r=deepfire a=Jimbo4350

Resolves: #4123

4285: Bench nix refactoring r=deepfire a=fmaste

Cleanups and refactorings that are needed to add the `Docker` backend alongside the `supervisord` backend

- Make backend files (here only `supervisor.nix`) as independent as possible.
- Created a backend subfolder.
- Extracted the code used as configuration for `generator-service`, `node-services` and `tracer-service` outside of the specific backend.
- Remove unused code in the process.

By looking at the individuals commits you can see the approach taken to evolve the code. Small/atomic steps and too much testing. History is for review purposes only, it's intended to be squashed when merged!

Co-authored-by: Jordan Millar <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
Co-authored-by: Federico Mastellone <[email protected]>
iohk-bors bot added a commit that referenced this issue Aug 11, 2022
4234: Update create-staked with the ability to specify relays for all created stake pools r=deepfire a=Jimbo4350

Resolves: #4123

Co-authored-by: Jordan Millar <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
iohk-bors bot added a commit that referenced this issue Aug 11, 2022
4234: Update create-staked with the ability to specify relays for all created stake pools r=deepfire a=Jimbo4350

Resolves: #4123

Co-authored-by: Jordan Millar <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
iohk-bors bot added a commit that referenced this issue Aug 11, 2022
4234: Update create-staked with the ability to specify relays for all created stake pools r=deepfire a=Jimbo4350

Resolves: #4123

Co-authored-by: Jordan Millar <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
@iohk-bors iohk-bors bot closed this as completed in 2b6a78c Aug 12, 2022
Repository owner moved this from In Progress to Done in Performance & Tracing Aug 12, 2022
@iohk-bors iohk-bors bot moved this to Done in Ouroboros Network Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer2peer Issues / PRs related to peer-2-peer
Projects
None yet
2 participants