-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update create-staked with the ability to specify relays for all created stake pools #4234
Merged
iohk-bors
merged 4 commits into
master
from
jordan/create-stake-inject-stake-pool-relays
Aug 12, 2022
Merged
Update create-staked with the ability to specify relays for all created stake pools #4234
iohk-bors
merged 4 commits into
master
from
jordan/create-stake-inject-stake-pool-relays
Aug 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy and
JaredCorduan
as code owners
July 25, 2022 20:40
Jimbo4350
force-pushed
the
jordan/create-stake-inject-stake-pool-relays
branch
4 times, most recently
from
July 26, 2022 18:29
aa67bc6
to
3e9d75e
Compare
command. This will allow the specification of the pool relays for all of the created stake pools
Jimbo4350
force-pushed
the
jordan/create-stake-inject-stake-pool-relays
branch
from
August 8, 2022 16:52
3e9d75e
to
06dea0d
Compare
…re than one relay per pool
deepfire
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integrated & tested -- good for BORS, from my side.
Thank you a lot @Jimbo4350 !
erikd
approved these changes
Aug 10, 2022
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 11, 2022
4234: Update create-staked with the ability to specify relays for all created stake pools r=deepfire a=Jimbo4350 Resolves: #4123 4285: Bench nix refactoring r=deepfire a=fmaste Cleanups and refactorings that are needed to add the `Docker` backend alongside the `supervisord` backend - Make backend files (here only `supervisor.nix`) as independent as possible. - Created a backend subfolder. - Extracted the code used as configuration for `generator-service`, `node-services` and `tracer-service` outside of the specific backend. - Remove unused code in the process. By looking at the individuals commits you can see the approach taken to evolve the code. Small/atomic steps and too much testing. History is for review purposes only, it's intended to be squashed when merged! Co-authored-by: Jordan Millar <[email protected]> Co-authored-by: Kosyrev Serge <[email protected]> Co-authored-by: Federico Mastellone <[email protected]>
bors r- |
Canceled. |
newhoggy
approved these changes
Aug 11, 2022
Example relays file:
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 11, 2022
4234: Update create-staked with the ability to specify relays for all created stake pools r=deepfire a=Jimbo4350 Resolves: #4123 Co-authored-by: Jordan Millar <[email protected]> Co-authored-by: Kosyrev Serge <[email protected]>
deepfire
force-pushed
the
jordan/create-stake-inject-stake-pool-relays
branch
from
August 11, 2022 04:02
6c5b9ae
to
62595bd
Compare
Canceled. |
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 11, 2022
4234: Update create-staked with the ability to specify relays for all created stake pools r=deepfire a=Jimbo4350 Resolves: #4123 Co-authored-by: Jordan Millar <[email protected]> Co-authored-by: Kosyrev Serge <[email protected]>
Build failed: |
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 11, 2022
4234: Update create-staked with the ability to specify relays for all created stake pools r=deepfire a=Jimbo4350 Resolves: #4123 Co-authored-by: Jordan Millar <[email protected]> Co-authored-by: Kosyrev Serge <[email protected]>
Build failed: |
deepfire
force-pushed
the
jordan/create-stake-inject-stake-pool-relays
branch
from
August 12, 2022 01:58
7d1bccc
to
3836ff7
Compare
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4123