Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion from device units to millimeters for future support of SR300/F200 sensors depth #46

Closed

Conversation

linknum23
Copy link

Changes proposed in this pull request:

  • Add conversion from device units to millimeters for future support of SR300/F200 sensors.

@linknum23 linknum23 changed the title Add conversion from device units to millimeters for future support of SR300/F200 sensors Add conversion from device units to millimeters for future support of SR300/F200 sensors depth Jun 6, 2016
@ghindman
Copy link

Hello, I apologize for the delayed response. We have been actively refactoring the code to support multiple camera architectures - #48 - and should be landing the changes in a few days. This PR will need to be rebased after the refactor since the code structure will have substantially changed.

@linknum23
Copy link
Author

It's a small change that you will likely put in the changes to support
multiple camera models. The push was meant mostly as a reminder for SR300
support. Let me know if you would like me merge this into the newly
refractored code.

On Tue, Jun 28, 2016, 9:17 PM Gavin Hindman [email protected]
wrote:

Hello, I apologize for the delayed response. We have been actively
refactoring the code to support multiple camera architectures - #48
#48 - and should be
landing the changes in a few days. This PR will need to be rebased after
the refactor since the code structure will have substantially changed.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#46 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAmXuw7_5rem0ZmeZfNAel1Y1Xi0qR_Uks5qQXNSgaJpZM4IvOME
.

mdhorn pushed a commit to mdhorn/realsense that referenced this pull request Jul 13, 2016
…stall-documentation

Update README to include rosdep install
@reaganlo
Copy link

@linknum23 Thanks for your contribution. These changes have been incorporated in #90 after refactoring it with the latest code. Closing this PR.

@reaganlo reaganlo closed this Aug 18, 2016
icarpis added a commit to icarpis/realsense that referenced this pull request Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants