-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_ordering (libcst.metadata.tests.test_scope_provider.ScopeProviderTest) fails on i586 and Python 3.6 #442
Comments
Additional info: The above build log was with 0.3.14, but the same error occurs on 0.3.16. |
It looks like the assertion took two Name objects looked the same but they were different one. Can you add some statements to print the id of those different |
And how would I get the "Id"? Here is a pickle dump string: import pickle
print("Debug:")
print("x.value = ")
print(pickle.dumps(x.value))
print("global_refs[0].node = ")
print(pickle.dumps(global_refs[0]))
self.assertEqual(x.value, global_refs[0].node)
|
This is a sorting issue.
LibCST/libcst/metadata/scope_provider.py Line 99 in f2cd39c
An order may be different on each launch of Python interpreter.
|
The test wrongly assumed that `first_assignment.references` is ordered collection, while actually it is `set`. Fixes: Instagram#442 Signed-off-by: Stanislav Levin <[email protected]>
The test wrongly assumed that `first_assignment.references` is ordered collection, while actually it is `set`. Fixes: Instagram#442 Signed-off-by: Stanislav Levin <[email protected]>
The test wrongly assumed that `first_assignment.references` is ordered collection, while actually it is `set`. Fixes: #442 Signed-off-by: Stanislav Levin <[email protected]>
When packaging LibCST for OpenSUSE the testsuite fails repeatedly on i586 with Python 3.6:
Complete build log with all details and versions of packages
The text was updated successfully, but these errors were encountered: