tests: Fix assumption about sorting in test_ordering #650
Conversation
|
Hi @stanislavlevin! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
The test wrongly assumed that `first_assignment.references` is ordered collection, while actually it is `set`. Fixes: Instagram#442 Signed-off-by: Stanislav Levin <[email protected]>
stanislavlevin
force-pushed
the
issue_442
branch
from
c4d1a2b to
d61f6cb
Compare
Codecov Report
@@ Coverage Diff @@
## main #650 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 247 247
Lines 25376 25377 +1
=======================================
+ Hits 24052 24053 +1
Misses 1324 1324
Continue to review full report at Codecov.
|
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
The test wrongly assumed that
first_assignment.referencesis ordered collection, while actually it is
set.Fixes: #442