tests: Fix assumption about sorting in test_ordering

The test wrongly assumed that `first_assignment.references` is ordered collection, while actually it is `set`. Fixes: Instagram#442 Signed-off-by: Stanislav Levin <[email protected]>
stanislavlevin · Feb 18, 2022 · c4d1a2b · c4d1a2b
1 parent f2cd39c
commit c4d1a2b
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/libcst/metadata/tests/test_scope_provider.py b/libcst/metadata/tests/test_scope_provider.py
@@ -1531,19 +1531,20 @@ class X:
         first_assignment = list(global_scope.assignments)[0]
         assert isinstance(first_assignment, cst.metadata.Assignment)
         self.assertEqual(first_assignment.node, import_stmt)
-        global_refs = list(first_assignment.references)
+        global_refs = first_assignment.references
         self.assertEqual(len(global_refs), 2)
+        global_refs_nodes = {x.node for x in global_refs}
         class_def = ensure_type(m.body[1], cst.ClassDef)
         x = ensure_type(
             ensure_type(class_def.body.body[0], cst.SimpleStatementLine).body[0],
             cst.Assign,
         )
-        self.assertEqual(x.value, global_refs[0].node)
+        self.assertIn(x.value, global_refs_nodes)
         class_b = ensure_type(
             ensure_type(class_def.body.body[1], cst.SimpleStatementLine).body[0],
             cst.Assign,
         )
-        self.assertEqual(class_b.value, global_refs[1].node)
+        self.assertIn(class_b.value, global_refs_nodes)
 
         class_accesses = list(scopes[x].accesses)
         self.assertEqual(len(class_accesses), 3)