Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: Default default-constructors of class templates in Core/Common #3878

Conversation

N-Dekker
Copy link
Contributor

Defaulted default-constructors that just set all data members to zero or null, and those that only just call their base class.

@github-actions github-actions bot added area:Core Issues affecting the Core module type:Style Style changes: no logic impact (indentation, comments, naming) labels Jan 20, 2023
@N-Dekker N-Dekker marked this pull request as ready for review January 20, 2023 21:21
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to fix conflicts.

Defaulted default-constructors that just set all data members to zero or null,
and those that only just call their base class.
@N-Dekker N-Dekker force-pushed the Default-constructors-Core-Common branch from f55e8c2 to 2ffd054 Compare January 23, 2023 16:08
@dzenanz dzenanz merged commit c2c67ac into InsightSoftwareConsortium:master Jan 25, 2023
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Mar 15, 2023
These default-constructors just either zero-initialized or default-constructed
all of their data members.

Follow-up to pull request InsightSoftwareConsortium#3878
commit c2c67ac
"STYLE: Default default-constructors of class templates in Core/Common"
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Mar 15, 2023
These default-constructors just simply either zero-initialized, cleared or
default-constructed all of their data members.

Follow-up to pull request InsightSoftwareConsortium#3878
commit c2c67ac
"STYLE: Default default-constructors of class templates in Core/Common"
hjmjohnson pushed a commit that referenced this pull request Mar 17, 2023
These default-constructors just simply either zero-initialized, cleared or
default-constructed all of their data members.

Follow-up to pull request #3878
commit c2c67ac
"STYLE: Default default-constructors of class templates in Core/Common"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Core Issues affecting the Core module type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants