Default default-constructor of ConstantBoundaryCondition and other Core/Common class templates #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Dekker
force-pushed
the
Default-default-constructors-Core-Common
branch
from
b70c5a2 to
32a7b06
Compare
dzenanz
approved these changes
Feb 16, 2023
N-Dekker
force-pushed
the
Default-default-constructors-Core-Common
branch
4 times, most recently
from
17f33b4 to
d1a5d36
Compare
This warning appeared on ITK.macOS Azure.Mac-1676593025693/Darwin-Build9696, Apple clang version 13.0.0 (clang-1300.0.29.30), just after _defaulting_ the default-constructor of `itk::CompensatedSummation`.
Defaulted the default-constructors of five SpatialFunction class templates: - BinaryThresholdSpatialFunction - EllipsoidInteriorExteriorSpatialFunction - GaussianDerivativeSpatialFunction - GaussianSpatialFunction - SphereSpatialFunction
Default the default-constructor of four Image class templates: - Image - SparseImage - SpecialCoordinatesImage - VectorImage
Defaulted the default-constructor of ImportImageContainer and ImportImageFilter
Also defaulted the default-constructor of MinPriorityQueueElementWrapper, and added in-class initializers to its data members.
N-Dekker
force-pushed
the
Default-default-constructors-Core-Common
branch
from
d1a5d36 to
d5fa8ae
Compare
github-actions
bot
added
the
type:Testing
N-Dekker
commented
Feb 17, 2023
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Sep 1, 2023
The constructors of `ImageRandomConstIteratorWithIndex` and `ImageRandomConstIteratorWithOnlyIndex` that support two arguments (image and region) accidentally still assigned their data members, while they were already initialized by in-class default member initialization. This in-class default member initialization was added as part of pull request InsightSoftwareConsortium#3929 commit 4e46cb6 "STYLE: Default default-constructor of ImageRandom ConstIterator classes", merged on February 24, 2023 and included with tag ITK v5.4rc01. This caused extra `MersenneTwisterRandomVariateGenerator::New()` calls, which changed the seeds of random number generation. These changes can possibly cause regression failures in unit tests of client applications, including elastix. This commit removes all data member assignments from the bodies of these constructors.
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to pull request #3878 "STYLE: Default default-constructors of class templates in Core/Common"