STYLE: Default default-constructors of class templates in Core/Common

Defaulted default-constructors that just set all data members to zero or null, and those that only just call their base class.
N-Dekker · Jan 25, 2023 · c2c67ac · c2c67ac
1 parent 2c5dec1
commit c2c67ac
Show file tree

Hide file tree

Showing 16 changed files with 8 additions and 58 deletions.
diff --git a/Modules/Core/Common/include/itkArray.h b/Modules/Core/Common/include/itkArray.h
@@ -56,7 +56,7 @@ class ITK_TEMPLATE_EXPORT Array : public vnl_vector<TValue>
 public:
   /** Default constructor. It is created with an empty array
    *  it has to be allocated later by assignment */
-  Array();
+  Array() = default;
 
   /** Copy constructor.  Uses VNL copy constructor with correct
    *  setting for memory management. */

diff --git a/Modules/Core/Common/include/itkArray.hxx b/Modules/Core/Common/include/itkArray.hxx
@@ -23,12 +23,6 @@
 namespace itk
 {
 
-template <typename TValue>
-Array<TValue>::Array()
-  : vnl_vector<TValue>()
-{}
-
-
 template <typename TValue>
 Array<TValue>::Array(const Self & rhs)
   : vnl_vector<TValue>(rhs)

diff --git a/Modules/Core/Common/include/itkBoundingBox.h b/Modules/Core/Common/include/itkBoundingBox.h
@@ -189,7 +189,7 @@ class ITK_TEMPLATE_EXPORT BoundingBox : public Object
   DeepCopy() const;
 
 protected:
-  BoundingBox();
+  BoundingBox() = default;
   ~BoundingBox() override = default;
   void
   PrintSelf(std::ostream & os, Indent indent) const override;

diff --git a/Modules/Core/Common/include/itkBoundingBox.hxx b/Modules/Core/Common/include/itkBoundingBox.hxx
@@ -125,13 +125,6 @@ BoundingBox<TPointIdentifier, VPointDimension, TCoordRep, TPointsContainer>::Get
 }
 #endif
 
-/** */
-template <typename TPointIdentifier, unsigned int VPointDimension, typename TCoordRep, typename TPointsContainer>
-BoundingBox<TPointIdentifier, VPointDimension, TCoordRep, TPointsContainer>::BoundingBox()
-  : m_PointsContainer(nullptr)
-{
-  m_Bounds.Fill(NumericTraits<CoordRepType>::ZeroValue());
-}
 
 template <typename TPointIdentifier, unsigned int VPointDimension, typename TCoordRep, typename TPointsContainer>
 bool

diff --git a/Modules/Core/Common/include/itkConicShellInteriorExteriorSpatialFunction.h b/Modules/Core/Common/include/itkConicShellInteriorExteriorSpatialFunction.h
@@ -121,7 +121,7 @@ class ITK_TEMPLATE_EXPORT ConicShellInteriorExteriorSpatialFunction
   itkBooleanMacro(Polarity);
 
 protected:
-  ConicShellInteriorExteriorSpatialFunction();
+  ConicShellInteriorExteriorSpatialFunction() = default;
   ~ConicShellInteriorExteriorSpatialFunction() override = default;
   void
   PrintSelf(std::ostream & os, Indent indent) const override;

diff --git a/Modules/Core/Common/include/itkConicShellInteriorExteriorSpatialFunction.hxx b/Modules/Core/Common/include/itkConicShellInteriorExteriorSpatialFunction.hxx
@@ -21,14 +21,6 @@
 
 namespace itk
 {
-template <unsigned int VDimension, typename TInput>
-ConicShellInteriorExteriorSpatialFunction<VDimension, TInput>::ConicShellInteriorExteriorSpatialFunction()
-
-{
-  m_Origin.Fill(0.0);
-  m_OriginGradient.Fill(0.0);
-}
-
 template <unsigned int VDimension, typename TInput>
 void
 ConicShellInteriorExteriorSpatialFunction<VDimension, TInput>::SetOriginGradient(GradientType grad)

diff --git a/Modules/Core/Common/include/itkFrustumSpatialFunction.h b/Modules/Core/Common/include/itkFrustumSpatialFunction.h
@@ -126,7 +126,7 @@ class ITK_TEMPLATE_EXPORT FrustumSpatialFunction : public InteriorExteriorSpatia
   itkSetMacro(RotationPlane, FrustumRotationPlaneType);
 
 protected:
-  FrustumSpatialFunction();
+  FrustumSpatialFunction() = default;
   ~FrustumSpatialFunction() override = default;
   void
   PrintSelf(std::ostream & os, Indent indent) const override;

diff --git a/Modules/Core/Common/include/itkFrustumSpatialFunction.hxx b/Modules/Core/Common/include/itkFrustumSpatialFunction.hxx
@@ -21,12 +21,6 @@
 
 namespace itk
 {
-template <unsigned int VDimension, typename TInput>
-FrustumSpatialFunction<VDimension, TInput>::FrustumSpatialFunction()
-{
-  m_Apex.Fill(0.0f);
-}
-
 template <unsigned int VDimension, typename TInput>
 auto
 FrustumSpatialFunction<VDimension, TInput>::Evaluate(const InputType & position) const -> OutputType

diff --git a/Modules/Core/Common/include/itkHeavisideStepFunction.h b/Modules/Core/Common/include/itkHeavisideStepFunction.h
@@ -79,7 +79,7 @@ class ITK_TEMPLATE_EXPORT HeavisideStepFunction : public HeavisideStepFunctionBa
   EvaluateDerivative(const InputType & input) const override;
 
 protected:
-  HeavisideStepFunction();
+  HeavisideStepFunction() = default;
   ~HeavisideStepFunction() override = default;
 };
 } // namespace itk

diff --git a/Modules/Core/Common/include/itkHeavisideStepFunction.hxx b/Modules/Core/Common/include/itkHeavisideStepFunction.hxx
@@ -22,10 +22,6 @@
 
 namespace itk
 {
-template <typename TInput, typename TOutput>
-HeavisideStepFunction<TInput, TOutput>::HeavisideStepFunction()
-  : Superclass()
-{}
 
 template <typename TInput, typename TOutput>
 auto

diff --git a/Modules/Core/Common/include/itkImageDuplicator.h b/Modules/Core/Common/include/itkImageDuplicator.h
@@ -115,7 +115,7 @@ class ITK_TEMPLATE_EXPORT ImageDuplicator : public Object
   Update();
 
 protected:
-  ImageDuplicator();
+  ImageDuplicator() = default;
   ~ImageDuplicator() override = default;
   void
   PrintSelf(std::ostream & os, Indent indent) const override;

diff --git a/Modules/Core/Common/include/itkImageDuplicator.hxx b/Modules/Core/Common/include/itkImageDuplicator.hxx
@@ -23,14 +23,6 @@
 namespace itk
 {
 
-template <typename TInputImage>
-ImageDuplicator<TInputImage>::ImageDuplicator()
-{
-  m_InputImage = nullptr;
-  m_DuplicateImage = nullptr;
-  m_InternalImageTime = 0;
-}
-
 template <typename TInputImage>
 void
 ImageDuplicator<TInputImage>::Update()

diff --git a/Modules/Core/Common/include/itkPriorityQueueContainer.h b/Modules/Core/Common/include/itkPriorityQueueContainer.h
@@ -162,7 +162,7 @@ class ITK_TEMPLATE_EXPORT MaxPriorityQueueElementWrapper
   using ElementIdentifierType = TElementIdentifier;
 
   using Superclass = MinPriorityQueueElementWrapper<ElementType, ElementPriorityType, ElementIdentifierType>;
-  MaxPriorityQueueElementWrapper();
+  MaxPriorityQueueElementWrapper() = default;
 
   MaxPriorityQueueElementWrapper(ElementType element, ElementPriorityType priority);
 

diff --git a/Modules/Core/Common/include/itkPriorityQueueContainer.hxx b/Modules/Core/Common/include/itkPriorityQueueContainer.hxx
@@ -184,10 +184,6 @@ MinPriorityQueueElementWrapper<TElement, TElementPriority, TElementIdentifier>::
 // -----------------------------------------------------------------------------
 // MaxPriorityQueueElementWrapper
 // -----------------------------------------------------------------------------
-template <typename TElement, typename TElementPriority, typename TElementIdentifier>
-MaxPriorityQueueElementWrapper<TElement, TElementPriority, TElementIdentifier>::MaxPriorityQueueElementWrapper()
-  : Superclass()
-{}
 // -----------------------------------------------------------------------------
 
 // -----------------------------------------------------------------------------

diff --git a/Modules/Core/Common/include/itkTorusInteriorExteriorSpatialFunction.h b/Modules/Core/Common/include/itkTorusInteriorExteriorSpatialFunction.h
@@ -79,7 +79,7 @@ class ITK_TEMPLATE_EXPORT TorusInteriorExteriorSpatialFunction
   itkSetMacro(MinorRadius, double);
 
 protected:
-  TorusInteriorExteriorSpatialFunction();
+  TorusInteriorExteriorSpatialFunction() = default;
   ~TorusInteriorExteriorSpatialFunction() override = default;
   void
   PrintSelf(std::ostream & os, Indent indent) const override;

diff --git a/Modules/Core/Common/include/itkTorusInteriorExteriorSpatialFunction.hxx b/Modules/Core/Common/include/itkTorusInteriorExteriorSpatialFunction.hxx
@@ -21,13 +21,6 @@
 
 namespace itk
 {
-template <unsigned int VDimension, typename TInput>
-TorusInteriorExteriorSpatialFunction<VDimension, TInput>::TorusInteriorExteriorSpatialFunction()
-
-{
-  m_Origin.Fill(0.0);
-}
-
 template <unsigned int VDimension, typename TInput>
 auto
 TorusInteriorExteriorSpatialFunction<VDimension, TInput>::Evaluate(const InputType & position) const -> OutputType