Feature/wind profiles #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Animal Module constants rework
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/new_abiotic_model #350 +/- ##
=============================================================
+ Coverage 95.79% 95.97% +0.17%
=============================================================
Files 55 56 +1
Lines 2595 2705 +110
=============================================================
+ Hits 2486 2596 +110
Misses 109 109 ☔ View full report in Codecov by Sentry. |
jacobcook1995
requested changes
Dec 5, 2023
| wind_reference_height=(self.data["canopy_height"] + 10).to_numpy(), | ||
| turbulence_sign=True, | ||
| abiotic_constants=AbioticConsts(), | ||
| core_constants=CoreConsts(), |
There was a problem hiding this comment.
Doesn't this make it impossible for the user to change the constants, because default values will always be used?
There was a problem hiding this comment.
oh yes, you're right. I copied the arguments and missed changing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the wind submodule to the new
abioticmodel. It is not very complex, basically just a long list of functions that in the end are called in theAbioticModel.@TaranRallings did you make some commits to this branch or did this come from
git merge develop? It looks like I missed an update, please ignore the animal files in the review, we can sort this out when I eventually merge in develop.The question came up about what the
required_init_varsshould contain regarding the dummy data set, please comment on #349 .Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks