Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animal Module constants rework #343

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

TaranRallings
Copy link
Collaborator

Description

This is the rework of constants handling in the animal module. Everything seems to be working but do let me know if I've misunderstood something about implementing constants in this way.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • [x All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You may need to add another constants class to the model if you end up using core constants (and this may just become part of the BaseModel signature) but see also #342 - this is still up in the air, so just to be aware of.

@TaranRallings TaranRallings merged commit 49e159c into develop Nov 28, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants