Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify role of required init vars #349

Closed
vgro opened this issue Dec 5, 2023 · 5 comments
Closed

Clarify role of required init vars #349

vgro opened this issue Dec 5, 2023 · 5 comments

Comments

@vgro
Copy link
Collaborator

vgro commented Dec 5, 2023

The question came up what exactly needs to go in the required_init_vars of a model to ensure that the dummy simulation runs. Is it all the input variables needed to run the model or only the ones that come from somewhere external, like ERA5 data?

@vgro vgro mentioned this issue Dec 5, 2023
7 tasks
@davidorme
Copy link
Collaborator

I think we probably need to discriminate between these two things. I think this is going to be at the heart of any attempt to freeze modules - some data has to be provided to start the model running, but others are generated from those. It's linked to the idea of what variables are provided by which module.

@vgro
Copy link
Collaborator Author

vgro commented Dec 5, 2023

Ok, so I include all the inputs that the model expects to run

@davidorme
Copy link
Collaborator

That it needs to __init__. I think in the near future we may end up defining all of these variables in their own register and provide a resolution process of which variables are populated by which models and which need to be provided etc.

@davidorme davidorme added this to the Core structures milestone Jan 9, 2024
@davidorme
Copy link
Collaborator

davidorme commented Mar 1, 2024

@dalonsoa - this is linked to #388. We might want to split required_init_vars into required_config_data and required_init_vars? It would be useful in the variable docs to be very clear about what data must be provided as an input and at the moment cannot be seen from required_init_vars. I guess we could work it out from required_init_vars and a new vars_initialised property across models, but it seems cleaner to be explicit!

@dalonsoa dalonsoa mentioned this issue Mar 20, 2024
8 tasks
@vgro
Copy link
Collaborator Author

vgro commented Jul 18, 2024

resolved with #388

@vgro vgro closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants