Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor highlight directive applying - 7.1.x #3767

Merged
merged 6 commits into from
Jan 31, 2019
Merged

Refactor highlight directive applying - 7.1.x #3767

merged 6 commits into from
Jan 31, 2019

Conversation

DiyanDimitrov
Copy link
Contributor

@DiyanDimitrov DiyanDimitrov commented Jan 30, 2019 •
edited
Loading

Closes #3520
Closes #3653
#3637
#3631

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@gedinakova gedinakova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jan 31, 2019
@gedinakova gedinakova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jan 31, 2019
@rkaraivanov rkaraivanov merged commit a08a790 into 7.1.x Jan 31, 2019
@rkaraivanov rkaraivanov deleted the ddimitrov/refactorHighlight branch January 31, 2019 16:19
rkaraivanov added a commit that referenced this pull request Oct 25, 2019
@rkaraivanov
perf(igx-grid): Reduce detection cycles in grid sizing logic
1f71d30 
Cleaned up most of the DOM handlers to use `fromEvent` thus avoiding
manual removing of event handlers.
Use the resize observer as an actual observable, removing the extra grid
subject for proxying the calls.
Finally removed the `ngOnChanges` hook in the cell as it was obsolete
since #3767 and #3916.

Closes #6031
@rkaraivanov rkaraivanov mentioned this pull request Oct 25, 2019
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

Assignees

@gedinakova gedinakova

Labels
grid: general grid: global-search grid: tree-grid version: 7.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DiyanDimitrov @rkaraivanov @kdinev @gedinakova