Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase rendering performance by circumventing the calcGridSizes last detectChanges call #6031

Closed
ChronosSF opened this issue Oct 22, 2019 · 1 comment
Closed

Increase rendering performance by circumventing the calcGridSizes last detectChanges call #6031

ChronosSF opened this issue Oct 22, 2019 · 1 comment
Assignees
@ChronosSF @MayaKirova @rkaraivanov @radomirchev
Labels
📈 enhancement Epic grid: general status: inactive Used to stale issues and pull requests

Comments

@ChronosSF
Copy link
Member

Description

During Ivy development @rkaraivanov noticed that removing the cdr.detectChanges() call before the scroll checker increases rendering performance by a significant margin. We should invest time to determine if this breaks anything and possibly fix it. At a first glance the grid functions correctly but this detection cycle is most likely indirectly taken advanged of during tests and this is why a lot of them fail
rkaraivanov added a commit that referenced this issue Oct 25, 2019
@rkaraivanov
perf(igx-grid): Reduce detection cycles in grid sizing logic
1f71d30 
Cleaned up most of the DOM handlers to use `fromEvent` thus avoiding
manual removing of event handlers.
Use the resize observer as an actual observable, removing the extra grid
subject for proxying the calls.
Finally removed the `ngOnChanges` hook in the cell as it was obsolete
since #3767 and #3916.

Closes #6031
@rkaraivanov rkaraivanov mentioned this issue Oct 25, 2019
Closed
14 tasks
rkaraivanov added a commit that referenced this issue Nov 13, 2019
@rkaraivanov
fix(igx-grid): Moved detection on stable ngzone
37d7a5d 
Closes #6031
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChronosSF ChronosSF

@MayaKirova MayaKirova

@rkaraivanov rkaraivanov

@radomirchev radomirchev

Labels
📈 enhancement Epic grid: general status: inactive Used to stale issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(igx-grid): Reduce detection cycles in grid sizing logic IgniteUI/igniteui-angular
4 participants
@ChronosSF @MayaKirova @rkaraivanov @radomirchev