Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When search and hide and then show a column the cell values are not correct #3631

Closed
nrobakova opened this issue Jan 16, 2019 · 1 comment · Fixed by #3658 or #3718
Closed

When search and hide and then show a column the cell values are not correct #3631

nrobakova opened this issue Jan 16, 2019 · 1 comment · Fixed by #3658 or #3718
Assignees
@gedinakova @DiyanDimitrov
Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium grid: general grid: global-search 🆕 status: new ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@nrobakova
Copy link
Contributor

Description

When hide a column search is not refreshed

  • igniteui-angular version: 7.2.x
  • browser: N/A

Steps to reproduce

  1. Open sample https://stackblitz.com/edit/angular-bxlhyt?file=src/app/grid/grid-search-sample/grid-search-sample.component.html
  2. In the search type "public"
  3. From the toolbar hide column "Selector Type"
  4. Show column "Selector Type"

Result

After step 3 the search is not refreshed
After step 4 the cell text is not correct

Expected result

After show/hide column search text should be updated like filtering for example.

Attachments

Attach a sample if available, and screenshots, if applicable.
image
@DiyanDimitrov DiyanDimitrov added the 🛠️ status: in-development Issues and PRs with active development on them label Jan 17, 2019
DiyanDimitrov added a commit that referenced this issue Jan 17, 2019
@DiyanDimitrov
test(search): add test for issue #3631
0019348
DiyanDimitrov added a commit that referenced this issue Jan 17, 2019
@DiyanDimitrov
fix(search): move highlight in afterViewChecked #3631
2d96d44
@DiyanDimitrov DiyanDimitrov mentioned this issue Jan 17, 2019
Merged
3 tasks
DiyanDimitrov added a commit that referenced this issue Jan 17, 2019
@DiyanDimitrov
test(search): add test for issue #3631
1fd3015
DiyanDimitrov added a commit that referenced this issue Jan 17, 2019
@DiyanDimitrov
fix(search): move highlight in afterViewChecked #3631
6314b5b
@DiyanDimitrov DiyanDimitrov mentioned this issue Jan 17, 2019
Merged
3 tasks
nrobakova added a commit that referenced this issue Jan 18, 2019
@nrobakova
test(grid): add search test for bug #3631
8a08fb5
nrobakova added a commit that referenced this issue Jan 18, 2019
@nrobakova
test(grid): add search test for bug #3631
e500d2a
@nrobakova nrobakova changed the title When hide a column global search is not refreshed When search and hide and then show a column the cell values are not correct Jan 23, 2019
gedinakova pushed a commit that referenced this issue Jan 24, 2019
@DiyanDimitrov @gedinakova
Fix - move highlight in ngAfterViewChecked (#3658)
15383bb 
* test(search): add test for issue #3631

* fix(search): move highlight in afterViewChecked #3631

* test(grid): add search test for bug #3631

* test(grid): Comment test related to bug #3691
@DiyanDimitrov
Copy link
Contributor

Reopen the issue since the applied fix has a performance impact.

@DiyanDimitrov DiyanDimitrov reopened this Jan 24, 2019
DiyanDimitrov added a commit that referenced this issue Jan 24, 2019
@DiyanDimitrov
fix(search): optimize value check for first change #3631
9ff985a
DiyanDimitrov added a commit that referenced this issue Jan 24, 2019
@DiyanDimitrov
fix(search): optimize value check for first change #3631
a72f218
This was referenced Jan 24, 2019
Merged
Merged
Aleksandyr pushed a commit that referenced this issue Jan 25, 2019
@DiyanDimitrov @Aleksandyr
test(search): add test for issue #3631
48db311
@gedinakova gedinakova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 25, 2019
gedinakova pushed a commit that referenced this issue Jan 25, 2019
@DiyanDimitrov @gedinakova
fix(search): optimize value check for first change #3631 (#3719)
8398ee2
gedinakova pushed a commit that referenced this issue Jan 25, 2019
@DiyanDimitrov @gedinakova
fix(search): optimize value check for first change #3631 (#3718)
aad3961
This was referenced Jan 30, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gedinakova gedinakova

@DiyanDimitrov DiyanDimitrov

Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium grid: general grid: global-search 🆕 status: new ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
4 participants
@nrobakova @tachojelev @gedinakova @DiyanDimitrov