Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor highlight directive applying #3772

Merged
merged 7 commits into from
Jan 31, 2019
Merged

Refactor highlight directive applying #3772

merged 7 commits into from
Jan 31, 2019

Conversation

DiyanDimitrov
Copy link
Contributor

Closes #3520
Closes #3653
#3637
#3631

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@DiyanDimitrov
test(search): add tests for #3520 and #3653
b93a52b
@DiyanDimitrov
feat(search): refactor highlight directive applying #3520
07fc8f4 
# Conflicts:
#	projects/igniteui-angular/src/lib/grids/cell.component.html
#	projects/igniteui-angular/src/lib/grids/cell.component.ts
@DiyanDimitrov
fix(search): fix highlight directive for tree cell #3520
4c56d24 
# Conflicts:
#	projects/igniteui-angular/src/lib/grids/tree-grid/tree-cell.component.html
@gedinakova gedinakova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jan 31, 2019
@gedinakova gedinakova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jan 31, 2019
@rkaraivanov rkaraivanov merged commit e48ea91 into master Jan 31, 2019
@rkaraivanov rkaraivanov deleted the ddimitrov/refactorHighlight-master branch January 31, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

Assignees

@gedinakova gedinakova

Labels
grid: general grid: global-search grid: tree-grid version: 7.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
3 participants
@DiyanDimitrov @rkaraivanov @gedinakova