Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculating grid's width when initialized with % based on its offsetWidth in IE11(master) #3097

Merged
merged 22 commits into from
Nov 27, 2018
Merged

Calculating grid's width when initialized with % based on its offsetWidth in IE11(master) #3097

merged 22 commits into from
Nov 27, 2018

Conversation

HristoP96
Copy link

@HristoP96 HristoP96 commented Nov 21, 2018 •
edited by kdinev
Loading

Closes #3095

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@HristoP96 HristoP96 added ❌ status: awaiting-test PRs awaiting manual verification grid: general browser: IE-11 Issues specific to the MS IE11 browser version: 7.0.x labels Nov 21, 2018
@HristoP96 HristoP96 requested review from tiliev and zdrawku November 21, 2018 17:08
HristoP96 pushed a commit that referenced this pull request Nov 21, 2018
fix(grid): Calculating grid's width based on its offsetWidth in IE11 #…
da160cf 
…3097
@tiliev tiliev added 💥 status: in-test PRs currently being tested ❌ status: awaiting-test PRs awaiting manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 22, 2018
@hanastasov hanastasov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 27, 2018
kdinev
kdinev previously approved these changes Nov 27, 2018
View reviewed changes
@HristoP96 HristoP96 changed the base branch from master to 7.0.x November 27, 2018 09:50
@HristoP96 HristoP96 changed the base branch from 7.0.x to master November 27, 2018 09:52
@zdrawku zdrawku changed the base branch from master to 7.0.x November 27, 2018 11:44
@zdrawku zdrawku changed the base branch from 7.0.x to master November 27, 2018 11:44
@rkaraivanov rkaraivanov changed the base branch from master to 7.0.x November 27, 2018 11:50
@kdinev kdinev merged commit ff7f8f0 into 7.0.x Nov 27, 2018
@kdinev kdinev deleted the hPopov/fix-bug-3095/fix-grids-width-IE11-master branch November 27, 2018 14:23
@HristoP96 HristoP96 mentioned this pull request Dec 7, 2018
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrawku zdrawku zdrawku approved these changes

@kdinev kdinev kdinev left review comments

@tiliev tiliev Awaiting requested review from tiliev

Assignees

@hanastasov hanastasov

Labels
browser: IE-11 Issues specific to the MS IE11 browser grid: general ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HristoP96 @kdinev @zdrawku @tiliev @hanastasov @ViktorSlavov @damyanpetev