Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Overlay - Overlay can properly render component w/o initial content #3133

Merged
merged 9 commits into from
Nov 27, 2018
Merged

Fix - Overlay - Overlay can properly render component w/o initial content #3133

merged 9 commits into from
Nov 27, 2018

Conversation

ViktorSlavov
Copy link
Contributor

@ViktorSlavov ViktorSlavov commented Nov 23, 2018 •
edited
Loading

Closes #3131

Additional information (check all that apply):

  • Bug fix

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code

@ViktorSlavov ViktorSlavov added 🛠️ status: in-development Issues and PRs with active development on them overlay version: 7.0.x labels Nov 23, 2018
@ViktorSlavov ViktorSlavov requested a review from wnvko November 23, 2018 12:13
@ViktorSlavov ViktorSlavov added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 26, 2018
@PlamenaMiteva PlamenaMiteva self-assigned this Nov 26, 2018
@PlamenaMiteva PlamenaMiteva added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 26, 2018
@kdinev kdinev changed the base branch from master to 7.0.x November 26, 2018 18:04
@kdinev kdinev changed the base branch from 7.0.x to master November 26, 2018 18:04
@kdinev kdinev merged commit 9718f10 into master Nov 27, 2018
@kdinev kdinev deleted the VSlavov/overlay-show-datepicker branch November 27, 2018 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdinev kdinev kdinev approved these changes

@wnvko wnvko Awaiting requested review from wnvko

Assignees

@PlamenaMiteva PlamenaMiteva

Labels
overlay version: 7.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[overlay] OverlayService show method doesn't display igx-calendar.
3 participants
@ViktorSlavov @kdinev @PlamenaMiteva