Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculating grid's width when initialized with % based on its offsetWidth in IE11(7.0.x) #3180

Closed
wants to merge 3 commits into from

Conversation

HristoP96
Copy link

#3095

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@HristoP96 HristoP96 added 🐛 bug Any issue that describes a bug ❌ status: awaiting-test PRs awaiting manual verification grid: general browser: IE-11 Issues specific to the MS IE11 browser version: 7.0.x labels Nov 27, 2018
@HristoP96 HristoP96 requested a review from zdrawku November 27, 2018 09:59
Copy link
Contributor

@mpavlinov mpavlinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed on every place that getComputedStyle is used. Extract the code in a function.

@HristoP96
Copy link
Author

The changes applied in this PR are merged in 7.0.x through PR 3097. @mpavlinov, after investigating the scenarios in which getComputedStyle is used, only the grid width set with % is broken in IE11.
In IE11 another rendering issue is caused when the grid is set with % and the columns don't have explicit width set. There is an issue about this behavior, which is currently in development.

@HristoP96 HristoP96 added status: already-fixed ❌ status: awaiting-test PRs awaiting manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification status: already-fixed labels Dec 7, 2018
@hanastasov hanastasov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Dec 7, 2018
@HristoP96 HristoP96 closed this Dec 7, 2018
@kdinev kdinev deleted the hPopov/fix-bug-3095/70x branch June 17, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: IE-11 Issues specific to the MS IE11 browser 🐛 bug Any issue that describes a bug grid: general version: 7.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants