Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Sidecars: Image pulling is now a debug log, try to guess log level of services #4232

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented May 12, 2023

What do these changes do?

  • dynamic sidecar image pulling logs downgraded to DEBUG level
  • computational sidecar image pulling is now a DEBUG message
  • new function to guess log level of a message by checking for (error,warning) prefixes in the message (very simple)
  • guessed log level is now used for parsing the logs of services (both dynamic and computational)

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:dynamic-sidecar dynamic-sidecar service label May 12, 2023
@sanderegg sanderegg added this to the Pastel de Nata milestone May 12, 2023
@sanderegg sanderegg self-assigned this May 12, 2023
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #4232 (2ba1e53) into master (fed9486) will increase coverage by 1.4%.
The diff coverage is 97.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4232     +/-   ##
========================================
+ Coverage    83.5%   85.0%   +1.4%     
========================================
  Files         955     911     -44     
  Lines       41456   40608    -848     
  Branches      955     879     -76     
========================================
- Hits        34649   34526    -123     
+ Misses       6589    5880    -709     
+ Partials      218     202     -16     
Flag Coverage Δ
integrationtests 61.9% <ø> (-6.7%) ⬇️
unittests 82.8% <97.0%> (+0.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vice_dynamic_sidecar/modules/long_running_tasks.py 95.5% <ø> (ø)
...dask_sidecar/computational_sidecar/docker_utils.py 93.1% <89.6%> (-0.1%) ⬇️
...dask_task_models_library/container_tasks/events.py 100.0% <100.0%> (ø)
...ls-library/src/models_library/rabbitmq_messages.py 90.6% <100.0%> (+0.2%) ⬆️
...es/service-library/src/servicelib/logging_utils.py 71.4% <100.0%> (+2.0%) ⬆️
...gs-library/src/settings_library/docker_registry.py 95.0% <100.0%> (-0.3%) ⬇️
...ce_dask_sidecar/computational_sidecar/constants.py 100.0% <100.0%> (ø)
...service_dask_sidecar/computational_sidecar/core.py 100.0% <100.0%> (ø)
...car/src/simcore_service_dask_sidecar/dask_utils.py 96.3% <100.0%> (+<0.1%) ⬆️
...car/src/simcore_service_dask_sidecar/file_utils.py 98.1% <100.0%> (+<0.1%) ⬆️
... and 4 more

... and 123 files with indirect coverage changes

@sanderegg sanderegg force-pushed the logs/make-image-pulling-debug branch from 5c7fbe9 to 34366df Compare May 14, 2023 20:27
@sanderegg sanderegg changed the title ♻️Dynamic sidecar: image pulling as debug logs ♻️Sidecars: Image pulling is now a debug log, try to guess log level of services May 15, 2023
@sanderegg sanderegg marked this pull request as ready for review May 15, 2023 10:03
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. some minor comments

@sanderegg sanderegg force-pushed the logs/make-image-pulling-debug branch from 08022de to 7156c24 Compare May 15, 2023 14:41
@sanderegg sanderegg force-pushed the logs/make-image-pulling-debug branch from 2534468 to 2ba1e53 Compare May 16, 2023 06:19
@sanderegg sanderegg enabled auto-merge (squash) May 16, 2023 06:19
@codeclimate
Copy link

codeclimate bot commented May 16, 2023

Code Climate has analyzed commit 2ba1e53 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented May 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants