-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Sidecars: Image pulling is now a debug log, try to guess log level of services #4232
♻️Sidecars: Image pulling is now a debug log, try to guess log level of services #4232
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4232 +/- ##
========================================
+ Coverage 83.5% 85.0% +1.4%
========================================
Files 955 911 -44
Lines 41456 40608 -848
Branches 955 879 -76
========================================
- Hits 34649 34526 -123
+ Misses 6589 5880 -709
+ Partials 218 202 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5c7fbe9
to
34366df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. some minor comments
packages/dask-task-models-library/src/dask_task_models_library/container_tasks/events.py
Outdated
Show resolved
Hide resolved
services/dask-sidecar/src/simcore_service_dask_sidecar/computational_sidecar/constants.py
Show resolved
Hide resolved
services/dask-sidecar/src/simcore_service_dask_sidecar/computational_sidecar/core.py
Outdated
Show resolved
Hide resolved
services/dask-sidecar/src/simcore_service_dask_sidecar/computational_sidecar/docker_utils.py
Outdated
Show resolved
Hide resolved
08022de
to
7156c24
Compare
fix types
2534468
to
2ba1e53
Compare
Code Climate has analyzed commit 2ba1e53 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Related issue/s
How to test
DevOps Checklist