image pulling as debug logs

ITISFoundation · May 12, 2023 · 5c7fbe9 · 5c7fbe9
1 parent afb9b0e
commit 5c7fbe9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/docker_compose_utils.py b/services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/docker_compose_utils.py
@@ -109,8 +109,8 @@ async def _progress_cb(current: int, total: int) -> None:
             float(current / (total or 1)),
         )
 
-    async def _log_cb(msg: str) -> None:
-        await post_sidecar_log_message(app, msg, log_level=logging.INFO)
+    async def _log_cb(msg: str, log_level: int) -> None:
+        await post_sidecar_log_message(app, msg, log_level=log_level)
 
     await pull_images(list_of_images, registry_settings, _progress_cb, _log_cb)
 

diff --git a/services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/docker_utils.py b/services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/docker_utils.py
@@ -2,7 +2,7 @@
 import logging
 from contextlib import asynccontextmanager
 from enum import Enum
-from typing import Any, AsyncGenerator, Awaitable, Callable, Final, Optional, TypedDict
+from typing import Any, AsyncGenerator, Awaitable, Callable, Final, TypedDict
 
 import aiodocker
 import yaml
@@ -69,7 +69,8 @@ def get_docker_service_images(compose_spec_yaml: str) -> set[str]:
 
 
 ProgressCB = Callable[[int, int], Awaitable[None]]
-LogCB = Callable[[str], Awaitable[None]]
+LogLevel = int
+LogCB = Callable[[str, LogLevel], Awaitable[None]]
 
 
 async def pull_images(
@@ -137,7 +138,7 @@ def _parse_docker_pull_progress(
     # {'status': 'Digest: sha256:27cb6e6ccef575a4698b66f5de06c7ecd61589132d5a91d098f7f3f9285415a9'}
     # {'status': 'Status: Downloaded newer image for ubuntu:latest'}
 
-    status: Optional[str] = docker_pull_progress.get("status")
+    status: str | None = docker_pull_progress.get("status")
 
     if status in list(_TargetPullStatus):
         assert "id" in docker_pull_progress  # nosec
@@ -238,4 +239,4 @@ async def _pull_image_with_progress(
             total_current, total_total = _compute_sizes(all_image_pulling_data)
             await progress_cb(total_current, total_total)
 
-        await log_cb(f"pulling {shorter_image_name}: {pull_progress}...")
+        await log_cb(f"pulling {shorter_image_name}: {pull_progress}...", logging.DEBUG)
diff --git a/services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/long_running_tasks.py b/services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/long_running_tasks.py
@@ -178,7 +178,7 @@ async def task_create_service_containers(
         application_health.error_message = message
         logger.error("Marked sidecar as unhealthy, see below for details\n:%s", message)
         await post_sidecar_log_message(
-            app, "could not start service containers", log_level=logging.INFO
+            app, "could not start service containers", log_level=logging.ERROR
         )
 
     return shared_store.container_names