-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Is686/api port schemas public api #3485
✨ Is686/api port schemas public api #3485
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3485 +/- ##
=========================================
+ Coverage 80.8% 82.2% +1.3%
=========================================
Files 42 710 +668
Lines 907 29943 +29036
Branches 6 553 +547
=========================================
+ Hits 733 24614 +23881
- Misses 174 5179 +5005
- Partials 0 150 +150
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6d9bfbb
to
b769f74
Compare
2c6d137
to
0bbfdbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good! please go ahead!
services/api-server/src/simcore_service_api_server/models/schemas/solvers.py
Show resolved
Hide resolved
0bbfdbd
to
add4511
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
✅ |
What do these changes do?
Follows up from PR #3484 and extends
api-server OAS version 0.4.1
:✨ Adds
/solvers/{service_key}/releases/{service_version}/ports
to the public API- NOTE: that this entrypoint is not displayed in the schema since it is marked as DEV_FEATURE (i.e.
API_SERVER_DEV_FEATURES_ENABLED
) to be released in next upgradeversion 0.5.0
Other changes:
openapi.yml
should not expose DEV_FEATUREscatalog
service API usingcatalog/openapi.json
specs. (seemocked_catalog_service_api
)api-server
Related issue/s
How to test
API_SERVER_DEV_FEATURES_ENABLED=1
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)