-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Is686/list_service_ports in catalog service API #3484
✨ Is686/list_service_ports in catalog service API #3484
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3484 +/- ##
========================================
+ Coverage 81.2% 81.5% +0.3%
========================================
Files 792 529 -263
Lines 33484 25472 -8012
Branches 744 133 -611
========================================
- Hits 27206 20773 -6433
+ Misses 6100 4650 -1450
+ Partials 178 49 -129
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bc46299
to
2e61c8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! a few questions and notes..
services/catalog/src/simcore_service_catalog/models/schemas/services_ports.py
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/models/schemas/services_ports.py
Outdated
Show resolved
Hide resolved
1f0a2b7
to
27e03eb
Compare
24ba336
to
828d83d
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Implements entrypoint in
catalog
service API to retrieve service ports: version: 0.3.2 → 0.4.0list_service_ports
entrypoint in catalog serviceget_service_from_registry
as dependency injectionFollowing PRs will connect this API to the api-server and expose it to the public (#3485)
Related issue/s
How to test
manual testing: use swagger
curl -X 'GET'
'http://127.0.0.1:8005/v0/services/simcore%2Fservices%2Fcomp%2Fitis%2Fsleeper/2.1.4/ports?user_id=1'
-H 'accept: application/json'
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)