Saml: Fix wrong baseurlpath in Saml README.md #8089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -103,7 +103,7 @@ The key `debug` is now not a boolean but an array value instead. New installatio | |||
| The key `baseurlpath` must be changed to the following. New installations will have this value as default. | |||
| ```diff | |||
| - 'baseurlpath' => 'simplesaml/', | |||
| + 'baseurlpath' => 'Services/saml/lib/', | |||
| + 'baseurlpath' => 'Services/Saml/lib/', | |||
There was a problem hiding this comment.
Hmmmm, in trunk we do not have Services anymore.
There was a problem hiding this comment.
Thats correct, but this is just to be consistent. This is the ILIAS 9 section, for ILIAS 10 there is also a section where this is addressed. So this place is just changed so it is consistent with ILIAS 9 README even though the documentation doesn't apply to ILIAS 10.
Here is the ILIAS 10 config change:
ILIAS/components/ILIAS/Saml/README.md
Line 144 in 783271b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR to #8088.