Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: exchange 'Services/*' and 'Modules/*' ref... #8110

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

lukastocker
Copy link
Contributor

...erences in MD files with 'components/ILIAS/*' - especially internal and external markdown references. (#42058)

https://mantis.ilias.de/view.php?id=42058

Note:

  1. docs/development/write-unit-tests.md and unit-test-usage.md should get rewritten - it's not up to date anymore.
  2. Links like "http://www.ilias.de/Services/MediaObjects/mob/4_1" were rewritten for consistency reasons even if the old and new URLs are not callable.
  3. Please change the entry in 'docs/configuration/secure.md' as the link is not available anymore and I could not find a alternative: "https://github.com/ILIAS-eLearning/ILIAS/blob/release_5-4/Services/FileDelivery/classes/override.php.template" in line 651

@lukastocker lukastocker force-pushed the 10_42058 branch 3 times, most recently from 0b1611a to 9a91f4d Compare September 27, 2024 06:47
@klees klees self-assigned this Sep 27, 2024
@@ -145,6 +145,6 @@ The key `NameIDPolicy` cannot be a string. It must be an array of the following

Due to the routing changes in ILIAS 10 the `baseurlpath` needs to be changed in the `$ILI_DATA/auth/saml/config/config.php`. New installations will have this value as default.
```diff
- 'baseurlpath' => 'Services/Saml/lib/',
- 'baseurlpath' => 'components/ILIAS/Saml/lib/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjansenDatabay Is this correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @klees ,

this is on our internal backlog since @lscharmer provided the change (to adopt the changes/correct path for ILIAS 9.x) to the ILIAS 10.x "README.md" with #8089 .

We will take care of this outside this PR (which has been already merged :-)).

Best regards,
Michael

references in MD files with 'components/ILIAS/*' - especially internal and external markdown references. (#42058)

https://mantis.ilias.de/view.php?id=42058
@klees klees merged commit 86b5838 into ILIAS-eLearning:trunk Sep 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants