Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saml: Fix wrong baseurlpath in Saml README.md #8089

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Saml: Fix wrong baseurlpath in Saml README.md #8089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/ILIAS/Saml/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ The key `debug` is now not a boolean but an array value instead. New installatio
The key `baseurlpath` must be changed to the following. New installations will have this value as default.
```diff
- 'baseurlpath' => 'simplesaml/',
+ 'baseurlpath' => 'Services/saml/lib/',
+ 'baseurlpath' => 'Services/Saml/lib/',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm, in trunk we do not have Services anymore.

Copy link
Contributor Author

@lscharmer lscharmer Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats correct, but this is just to be consistent. This is the ILIAS 9 section, for ILIAS 10 there is also a section where this is addressed. So this place is just changed so it is consistent with ILIAS 9 README even though the documentation doesn't apply to ILIAS 10.

Here is the ILIAS 10 config change:

ILIAS/components/ILIAS/Saml/README.md

Line 144 in 783271b

## Config Changes in ILIAS 10

```

If it does not already exist the key `module.enable` must be added with the following content. New installations will have this value as default.
Expand Down
Loading