Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace PREG_REPLACE_EVAL (Improving security + support for HHVM RepoAuthoritative) #5

Merged
merged 2 commits into from
Mar 21, 2015
Merged

Replace PREG_REPLACE_EVAL (Improving security + support for HHVM RepoAuthoritative) #5

merged 2 commits into from
Mar 21, 2015

Conversation

colin-kiegel
Copy link
Contributor

Replacing PREG_REPLACE_EVAL by PREG_REPLACE_CALLBACK to improve compatibility with HHVM RepoAuthoritative and overall security.

Note: PREG_REPLACE_EVAL has been DEPRECATED as of PHP 5.5.0. Relying on this feature is highly discouraged (php.net docs).

@colin-kiegel
Replacing PREG_REPLACE_EVAL by PREG_REPLACE_CALLBACK to improve compa…
0ad90f6 
…tibility with HHVM RepoAuthoritative and overall security.

 Note: PREG_REPLACE_EVAL has been DEPRECATED as of PHP 5.5.0. Relying on this feature is highly discouraged (php.net docs).
@colin-kiegel
fixed typo
bf08c09
@colin-kiegel colin-kiegel mentioned this pull request Mar 21, 2015
Merged
alex40724 pushed a commit that referenced this pull request Mar 21, 2015
Merge pull request #5 from colin-kiegel/trunk_preg_replace_callbacks
01aafd5 
Replace PREG_REPLACE_EVAL (Improving security + support for HHVM RepoAuthoritative)
@alex40724 alex40724 merged commit 01aafd5 into ILIAS-eLearning:trunk Mar 21, 2015
@colin-kiegel colin-kiegel deleted the trunk_preg_replace_callbacks branch March 23, 2015 22:14
bheyser pushed a commit to ILIAS-Verein/IIC50 that referenced this pull request Aug 21, 2015
lok3 ILIAS-eLearning#5 (bheyser)
9d14077
smeyer-ilias added a commit that referenced this pull request Aug 26, 2015
@smeyer-ilias
Search CDATE: #5
2be3f92
klees referenced this pull request in klees/ILIAS Oct 22, 2015
@shecken
Merge pull request #5 from klees/4_4_seepex
1012bfa 
SPX: Diverse Bugfixes
tomaszkolonko pushed a commit to tomaszkolonko/ILIAS that referenced this pull request Aug 18, 2016
@Amstutz
Merge pull request ILIAS-eLearning#5 from tomaszkolonko/trunk_gui_tz
9fba46e 
add user fix and updated language variables
chfsx added a commit that referenced this pull request Aug 25, 2017
@chfsx
Merge pull request #5 from klees/trunk_ia_positions
9ca6c14 
Table for Position-Permission-Settings at Objects
okaufman pushed a commit to okaufman/ILIAS that referenced this pull request Aug 12, 2019
@mjansenDatabay
Merge pull request ILIAS-eLearning#5 from mjansenDatabay/tooltip-infos
0734e9c 
Additional descriptions for tooltips
@nmatuschek nmatuschek mentioned this pull request Mar 5, 2020
Merged
@KamuiXenom KamuiXenom mentioned this pull request Mar 22, 2020
Merged
KamuiXenom added a commit to KamuiXenom/ILIAS that referenced this pull request Mar 23, 2020
@KamuiXenom
Fix ilCronManager::runJob:95 count(): Parameter must be an array or a…
a06a385 
…n object that implements Countable

Fixing error by using ldap-user-sync.

replace debug message after checking for an array

ERROR-LOG:

ilCronManager::runJob:95 count(): Parameter must be an array or an object that implements Countable
ilCronManager::runJob:95 #0 ILIAS_PATH/Services/Init/classes/class.ilErrorHandling.php(461): Whoops\Run->handleError(2, 'count(): Parame...', 'ILIAS_PATH...', 387)
ILIAS-eLearning#1 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPQuery.php(387): ilErrorHandling->handlePreWhoops(2, 'count(): Parame...', 'ILIAS_PATH...', 387, Array)
ILIAS-eLearning#2 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPQuery.php(131): ilLDAPQuery->fetchGroupMembers()
ILIAS-eLearning#3 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPCronSynchronization.php(87): ilLDAPQuery->fetchUsers()
ILIAS-eLearning#4 ILIAS_PATH/Services/Cron/classes/class.ilCronManager.php(178): ilLDAPCronSynchronization->run()
ILIAS-eLearning#5 ILIAS_PATH/Services/Cron/classes/class.ilCronManager.php(95): ilCronManager::runJob(Object(ilLDAPCronSynchronization), Array, true)
ILIAS-eLearning#6 ILIAS_PATH/Services/Cron/classes/class.ilCronManagerGUI.php(282): ilCronManager::runJobManual('ldap_sync')
ILIAS-eLearning#7 ILIAS_PATH/Services/Cron/classes/class.ilCronManagerGUI.php(64): ilCronManagerGUI->confirmedRun()
ILIAS-eLearning#8 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilCronManagerGUI->executeCommand()
ILIAS-eLearning#9 ILIAS_PATH/Modules/SystemFolder/classes/class.ilObjSystemFolderGUI.php(152): ilCtrl->forwardCommand(Object(ilCronManagerGUI))
ILIAS-eLearning#10 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilObjSystemFolderGUI->executeCommand()
ILIAS-eLearning#11 ILIAS_PATH/Services/Administration/classes/class.ilAdministrationGUI.php(250): ilCtrl->forwardCommand(Object(ilObjSystemFolderGUI))
ILIAS-eLearning#12 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilAdministrationGUI->executeCommand()
ILIAS-eLearning#13 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(175): ilCtrl->forwardCommand(Object(ilAdministrationGUI))
ILIAS-eLearning#14 ILIAS_PATH/ilias.php(20): ilCtrl->callBaseClass()
ILIAS-eLearning#15 {main}
@KamuiXenom KamuiXenom mentioned this pull request Mar 23, 2020
Merged
Amstutz added a commit to ezenzen/ILIAS that referenced this pull request Mar 11, 2021
@Amstutz
Merge pull request ILIAS-eLearning#5 from ezenzen/css_squad_branch_ze…
cde9249 
…nzen

Further CSS Changes
utesche pushed a commit to utesche/ILIAS that referenced this pull request Nov 16, 2021
var $retypeavalue needs initialization
14cf688 
When logging in as root for the very first time, the dialog for the mandatory password change is about to shown - but ends up in a sequence of 10 similar execeptions, each complaining about the same issue:

[978n6] [2021-11-16 10:43:11.379261] trunk8_root.ERROR: Whoops\Handler\CallbackHandler::handle:370 0 Typed property ilPasswordInputGUI::$retypevalue must not be accessed before initialization in /***/trunk8/Services/Form/classes/class.ilPasswordInputGUI.php:77#0 /***/trunk8/Services/Form/classes/class.ilPasswordInputGUI.php(245): ilPasswordInputGUI->getRetypeValue()
#1 /***/trunk8/Services/Form/classes/class.ilPasswordInputGUI.php(287): ilPasswordInputGUI->render()
#2 /***/trunk8/Services/Form/classes/class.ilPropertyFormGUI.php(665): ilPasswordInputGUI->insert()
#3 /***/trunk8/Services/Form/classes/class.ilPropertyFormGUI.php(560): ilPropertyFormGUI->insertItem()
ILIAS-eLearning#4 /***/trunk8/Services/Form/classes/class.ilFormGUI.php(126): ilPropertyFormGUI->getContent()
ILIAS-eLearning#5 /***/trunk8/Services/Form/classes/class.ilPropertyFormGUI.php(798): ilFormGUI->getHTML()
ILIAS-eLearning#6 /***/trunk8/Services/User/Settings/classes/class.ilPersonalSettingsGUI.php(197): ilPropertyFormGUI->getHTML()
ILIAS-eLearning#7 /***/trunk8/Services/User/Settings/classes/class.ilPersonalSettingsGUI.php(79): ilPersonalSettingsGUI->showPassword()
ILIAS-eLearning#8 /***/trunk8/Services/UICore/classes/class.ilCtrl.php(215): ilPersonalSettingsGUI->executeCommand()
ILIAS-eLearning#9 /***/trunk8/Services/Dashboard/classes/class.ilDashboardGUI.php(122): ilCtrl->forwardCommand()
ILIAS-eLearning#10 /***/trunk8/Services/UICore/classes/class.ilCtrl.php(215): ilDashboardGUI->executeCommand()
ILIAS-eLearning#11 /***/trunk8/Services/UICore/classes/class.ilCtrl.php(176): ilCtrl->forwardCommand()
ILIAS-eLearning#12 /***/trunk8/ilias.php(19): ilCtrl->callBaseClass()
ILIAS-eLearning#13 {main}
This was referenced Nov 16, 2021
Closed
Merged
katringross added a commit that referenced this pull request Dec 17, 2021
@katringross
Merge pull request #5 from kroepelin-projekte/Types
209a0fb 
Types
utesche pushed a commit to utesche/ILIAS that referenced this pull request May 3, 2022
ilStaticCache::set() must return bool
4bfcd46 
Hi Fabian,

a PHP Fatal Error occurs when performing setup command 'migrate':

PHP Fatal error:  Uncaught ILIAS\Setup\UnachievableException: Problem in DB-Update: 0 Return value of ilStaticCache::set() must be of the type bool, array returned in /***/trunk8/Services/GlobalCache/classes/Static/class.ilStaticCache.php:33#0 /***/trunk8/Services/GlobalCache/classes/class.ilGlobalCache.php(307): ilStaticCache->set()
#1 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(62): ilGlobalCache->set()
#2 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(29): ilCachedLanguage->writeToCache()
#3 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(107): ilCachedLanguage->__construct()
ILIAS-eLearning#4 /***/trunk8/Services/Language/classes/class.ilLanguage.php(91): ilCachedLanguage::getInstance()
ILIAS-eLearning#5 /***/trunk8/Services/Language/classes/class.ilLanguage.php(374): ilLanguage->__construct in /***/trunk8/Services/Database/classes/Setup/class.ilDatabaseUpdatedObjective.php on line 72
@utesche utesche mentioned this pull request May 3, 2022
Merged
utesche pushed a commit to utesche/ILIAS that referenced this pull request May 19, 2022
bugfix: ilObjOrgUnitTree::$temporary_table_name needs initialization
af3d328 
when requesting "Profile and Privacy" from metabar menu, the following error is thrown:

Error thrown with message "Typed static property ilObjOrgUnitTree::$temporary_table_name must not be accessed before initialization"
Stacktrace:
ILIAS-eLearning#12 Error in /srv/www/xyz/Modules/OrgUnit/classes/class.ilObjOrgUnitTree.php:375
ILIAS-eLearning#11 ilObjOrgUnitTree:buildTempTableWithUsrAssignements in /srv/www/xyz/Modules/OrgUnit/classes/PathStorage/class.ilOrgUnitPathStorage.php:77
ILIAS-eLearning#10 ilOrgUnitPathStorage:getTextRepresentationOfUsersOrgUnits in /srv/www/xyz/Services/User/classes/class.ilObjUser.php:2586
ILIAS-eLearning#9 ilObjUser:lookupOrgUnitsRepresentation in /srv/www/xyz/Services/User/classes/class.ilObjUser.php:2591
ILIAS-eLearning#8 ilObjUser:getOrgUnitsRepresentation in /srv/www/xyz/Services/User/classes/class.ilUserProfile.php:785
ILIAS-eLearning#7 ilUserProfile:addStandardFieldsToForm in /srv/www/xyz/Services/User/Profile/classes/class.ilPersonalProfileGUI.php:632
ILIAS-eLearning#6 ilPersonalProfileGUI:initPersonalDataForm in /srv/www/xyz/Services/User/Profile/classes/class.ilPersonalProfileGUI.php:582
ILIAS-eLearning#5 ilPersonalProfileGUI:showPersonalData in /srv/www/xyz/Services/User/Profile/classes/class.ilPersonalProfileGUI.php:122
ILIAS-eLearning#4 ilPersonalProfileGUI:executeCommand in /srv/www/xyz/Services/UICore/classes/class.ilCtrl.php:178
#3 ilCtrl:forwardCommand in /srv/www/xyz/Services/Dashboard/classes/class.ilDashboardGUI.php:107
#2 ilDashboardGUI:executeCommand in /srv/www/xyz/Services/UICore/classes/class.ilCtrl.php:178
#1 ilCtrl:forwardCommand in /srv/www/xyz/Services/UICore/classes/class.ilCtrl.php:153
#0 ilCtrl:callBaseClass in /srv/www/xyz/ilias.php:24
@utesche utesche mentioned this pull request May 19, 2022
Closed
fhelfer referenced this pull request in fhelfer/ILIAS Apr 20, 2023
@fhelfer
review dashboard #5
fcf31cd
fhelfer referenced this pull request in fhelfer/ILIAS Apr 20, 2023
@fhelfer
review dashboard #5
f4ee3b3
fhelfer referenced this pull request in fhelfer/ILIAS Apr 24, 2023
@fhelfer
review dashboard #5
2ea60b6
fhelfer referenced this pull request in fhelfer/ILIAS Apr 28, 2023
@fhelfer
review dashboard #5
3d3981a
fhelfer referenced this pull request in fhelfer/ILIAS May 8, 2023
@fhelfer
review dashboard #5
4d2cf27
fhelfer referenced this pull request in fhelfer/ILIAS May 25, 2023
@fhelfer
review dashboard #5
3b7d149
fhelfer referenced this pull request in fhelfer/ILIAS Jun 22, 2023
@fhelfer
review dashboard #5
d229860
fhelfer referenced this pull request in fhelfer/ILIAS Jun 26, 2023
@fhelfer
review dashboard #5
ad1c4ee
This was referenced Sep 11, 2023
Merged
Merged
@dsstrassner dsstrassner mentioned this pull request Oct 26, 2023
Merged
eozkeskin added a commit to eozkeskin/ILIAS that referenced this pull request Apr 22, 2024
@eozkeskin
Fix: Type error. ilObjSurvey::getAnonymousIdByCode()
bc467b3 
TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned"

Stacktrace:
ILIAS-eLearning#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702
ILIAS-eLearning#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175
ILIAS-eLearning#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354
ILIAS-eLearning#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280
ILIAS-eLearning#5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140
ILIAS-eLearning#4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
ILIAS-eLearning#3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206
ILIAS-eLearning#2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174
#0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
alex40724 pushed a commit that referenced this pull request Apr 22, 2024
@eozkeskin
Fix: Type error. ilObjSurvey::getAnonymousIdByCode() (#7410)
31a934a 
TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned"

Stacktrace:
#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702
#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175
#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354
#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280
#5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140
#4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206
#2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174
#0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
alex40724 added a commit that referenced this pull request Apr 22, 2024
@alex40724
Fix: Type error. ilObjSurvey::getAnonymousIdByCode() (#7410)
b5648ea 
TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned"

Stacktrace:
#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702
#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175
#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354
#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280
#5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140
#4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206
#2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174
#0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
alex40724 added a commit that referenced this pull request Apr 22, 2024
@alex40724
Fix: Type error. ilObjSurvey::getAnonymousIdByCode() (#7410)
958f5ee 
TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned"

Stacktrace:
#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702
#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175
#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354
#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280
#5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140
#4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206
#2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174
#0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
@fhelfer fhelfer mentioned this pull request Jun 5, 2024
Merged
@dsstrassner dsstrassner mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alex40724 alex40724

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-kiegel @alex40724