Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T&A, 39119: MultiSelect for Taxonomy Filter #7596

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

nhaagen
Copy link
Contributor

@nhaagen nhaagen commented Jun 3, 2024

@dsstrassner dsstrassner added bugfix php Pull requests that update Php code labels Jun 3, 2024
@dsstrassner
Copy link
Contributor

Hi @nhaagen,

sorry for the delay. I got an

Whoops\Exception\ErrorException thrown with message "Undefined array key "lft""

Stacktrace:
#17 Whoops\Exception\ErrorException in /var/www/html/Modules/TestQuestionPool/classes/class.ilAssQuestionList.php:652
#16 ilErrorHandling:handlePreWhoops in /var/www/html/Modules/TestQuestionPool/classes/class.ilAssQuestionList.php:652
#15 ilAssQuestionList:loadTaxonomyAssignmentData in /var/www/html/Modules/TestQuestionPool/classes/class.ilAssQuestionList.php:583
#14 ilAssQuestionList:load in /var/www/html/Modules/TestQuestionPool/classes/QuestionTable.php:220
#13 QuestionTable:getTotalRowCount in /var/www/html/src/UI/Implementation/Component/Table/Data.php:400
#12 ILIAS\UI\Implementation\Component\Table\Data:applyViewControls in /var/www/html/src/UI/Implementation/Component/Table/Renderer.php:231
#11 ILIAS\UI\Implementation\Component\Table\Renderer:renderDataTable in /var/www/html/src/UI/Implementation/Component/Table/Renderer.php:48
#10 ILIAS\UI\Implementation\Component\Table\Renderer:render in /var/www/html/src/UI/Implementation/DefaultRenderer.php:60
#9 ILIAS\UI\Implementation\DefaultRenderer:render in /var/www/html/src/UI/Implementation/DefaultRenderer.php:56
#8 ILIAS\UI\Implementation\DefaultRenderer:render in /var/www/html/Modules/TestQuestionPool/classes/class.ilObjQuestionPoolGUI.php:1942
#7 ilObjQuestionPoolGUI:getTable in /var/www/html/Modules/TestQuestionPool/classes/class.ilObjQuestionPoolGUI.php:1288
#6 ilObjQuestionPoolGUI:questionsObject in /var/www/html/Modules/TestQuestionPool/classes/class.ilObjQuestionPoolGUI.php:577
#5 ilObjQuestionPoolGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:119
#4 ilCtrl:forwardCommand in /var/www/html/Services/Repository/classes/class.ilRepositoryGUI.php:243
#3 ilRepositoryGUI:show in /var/www/html/Services/Repository/classes/class.ilRepositoryGUI.php:223
#2 ilRepositoryGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:119
#1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:92
#0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24

after I imported an Question Pool with taxonomy in doil, select some nodes in the filter and deleted the nodes afterwards and tried to open the questions tab again ;-)

@dsstrassner
Copy link
Contributor

dsstrassner commented Jun 17, 2024

Another Copy of this pool. Selected "Questions without assigned Taxonomy", but the filter does not filter the questions with taxonomies out:

image

Selected Node "Fachspezifische Fragetypen", but got also another question without this node shown:

image

Edit: got it: This "Fachspezifische Fragetypen" Node has 2 Sub-Nodes: "MINT" and "Sprachen"

Question Pool Export:
1718622465__4105__qpl_191594.zip

@dsstrassner
Copy link
Contributor

I created https://mantis.ilias.de/view.php?id=41533 to document the sub-node issue in the current implementation.

@nhaagen
Copy link
Contributor Author

nhaagen commented Jul 4, 2024

I updated the filter respecting all levels of the tax-tree as well as the representation of selected taxonomies.:

Screenshot from 2024-07-04 11-08-12

@dsstrassner
Copy link
Contributor

Thanks, @nhaagen!
From my point of view, everything seems fine now. Please go on @thojou

@thojou thojou merged commit 4a71c22 into ILIAS-eLearning:release_9 Jul 15, 2024
3 checks passed
@thojou
Copy link
Contributor

thojou commented Jul 15, 2024

Hey @nhaagen,

I took your PR and integrated the changes into trunk.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants