Forum Bugfix: ForumDraftsTable fix DataTable expects DateTimeImmutable #7610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjansenDatabay
requested changes
Jun 5, 2024
mjansenDatabay
requested changes
Jun 5, 2024
fhelfer
force-pushed
the
forum/bugfix/drafttable
branch
from
044f42a to
e80b760
Compare
|
edit: PR also adds a check for user timeformat in drafttable |
Change Forum Draft Timezone to system timezone Remove Timezone from ForumDrafTable
fhelfer
force-pushed
the
forum/bugfix/drafttable
branch
from
10cc6ae to
3dbbff6
Compare
|
Thx Fabian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ForumDraftsTable currently throws following error, this PR fixes it
InvalidArgumentException thrown with message "Argument 'value': expected DateTimeImmutable, got ilDateTime"
Stacktrace:
22 InvalidArgumentException in /var/www/ilias_v2/ILIAS/components/ILIAS/UI/src/Implementation/Component/ComponentHelper.php:64
21 ILIAS\UI\Implementation\Component\Table\Column\Column:checkArg in /var/www/ilias_v2/ILIAS/components/ILIAS/UI/src/Implementation/Component/ComponentHelper.php:113
20 ILIAS\UI\Implementation\Component\Table\Column\Column:checkArgInstanceOf in /var/www/ilias_v2/ILIAS/components/ILIAS/UI/src/Implementation/Component/Table/Column/Date.php:43
19 ILIAS\UI\Implementation\Component\Table\Column\Date:format in /var/www/ilias_v2/ILIAS/components/ILIAS/UI/src/Implementation/Component/Table/DataRow.php:99
18 ILIAS\UI\Implementation\Component\Table\DataRow:getCellContent in /var/www/ilias_v2/ILIAS/components/ILIAS/UI/src/Implementation/Component/Table/Renderer.php:573
17 ILIAS\UI\Implementation\Component\Table\Renderer:fillCells in /var/www/ilias_v2/ILIAS/components/ILIAS/UI/src/Implementation/Component/Table/Renderer.php:524
16 ILIAS\UI\Implementation\Component\Table\Renderer:renderDataRow in /var/www/ilias_v2/ILIAS/components/ILIAS/UI/src/Implementation/Component/Table/Renderer.php:55
15 ILIAS\UI\Implementation\Component\Table\Renderer:render in /var/www/ilias_v2/ILIAS/components/ILIAS/UI/src/Implementation/DefaultRenderer.php:60
14 ILIAS\UI\Implementation\DefaultRenderer:render in /var/www/ilias_v2/ILIAS/components/ILIAS/UI/src/Implementation/Component/Table/Renderer.php:401
13 ILIAS\UI\Implementation\Component\Table\Renderer:appendTableRows in /var/www/ilias_v2/ILIAS/components/ILIAS/UI/src/Implementation/Component/Table/Renderer.php:236
12 ILIAS\UI\Implementation\Component\Table\Renderer:renderDataTable in /var/www/ilias_v2/ILIAS/components/ILIAS/UI/src/Implementation/Component/Table/Renderer.php:50
11 ILIAS\UI\Implementation\Component\Table\Renderer:render in /var/www/ilias_v2/ILIAS/components/ILIAS/UI/src/Implementation/DefaultRenderer.php:60
10 ILIAS\UI\Implementation\DefaultRenderer:render in /var/www/ilias_v2/ILIAS/components/ILIAS/Forum/classes/class.ilObjForumGUI.php:1141
9 ilObjForumGUI:addDraftButtonIfDraftsExists in /var/www/ilias_v2/ILIAS/components/ILIAS/Forum/classes/class.ilObjForumGUI.php:750
8 ilObjForumGUI:getContent in /var/www/ilias_v2/ILIAS/components/ILIAS/ILIASObject/classes/class.ilObjectGUI.php:1547
7 ilObjectGUI:getCenterColumnHTML in /var/www/ilias_v2/ILIAS/components/ILIAS/Forum/classes/class.ilObjForumGUI.php:700
6 ilObjForumGUI:showThreadsObject in /var/www/ilias_v2/ILIAS/components/ILIAS/Forum/classes/class.ilObjForumGUI.php:580
5 ilObjForumGUI:executeCommand in /var/www/ilias_v2/ILIAS/components/ILIAS/UICore/classes/class.ilCtrl.php:119
4 ilCtrl:forwardCommand in /var/www/ilias_v2/ILIAS/components/ILIAS/Repository/classes/class.ilRepositoryGUI.php:246
3 ilRepositoryGUI:show in /var/www/ilias_v2/ILIAS/components/ILIAS/Repository/classes/class.ilRepositoryGUI.php:226
2 ilRepositoryGUI:executeCommand in /var/www/ilias_v2/ILIAS/components/ILIAS/UICore/classes/class.ilCtrl.php:119
1 ilCtrl:forwardCommand in /var/www/ilias_v2/ILIAS/components/ILIAS/UICore/classes/class.ilCtrl.php:92
0 ilCtrl:callBaseClass in /var/www/ilias_v2/ILIAS/public/ilias.php:24