Ensured that columns in the Data Grid can be deleted even when there are no key columns #8422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lilyclements please can you forward the message from CIMH about this error? I am not quite sure what to test. |
|
@rdstern My mistake - I put the wrong title for the wrong PR. The relevant PR is #8419 and I have given an outline on that PR of the issue. We've discussed before about doing more readable issue titles - while more readable to 99.9% of people, I do not operate using actual words so got two issues mixed up when replacing a PR! Sorry about that. |
lilyclements
changed the title
rdstern
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
@lilyclements still looks fine. @lloyddewit can this be merged?
lloyddewit
approved these changes
Jul 10, 2023
This was referenced Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #8416
@lloyddewit @rdstern this is ready to review