Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete columns sometimes doesn't work anymore #8413

Closed
rdstern opened this issue Jun 30, 2023 · 5 comments · Fixed by #8433
Closed

Delete columns sometimes doesn't work anymore #8413

rdstern opened this issue Jun 30, 2023 · 5 comments · Fixed by #8433

Comments

@rdstern
Copy link
Collaborator

rdstern commented Jun 30, 2023

I am using the merged version of R-Instat

@Vitalis95 and @lilyclements I am pretty sure this bug has followed the merging of pull request #8398.

I read in the usual survey and immediately tried to delete the columns as shown below. It doesn't work anymore:
It should be easy to fix as I explain below:

image
.
I suggest the problem is that deleting a column, now checks and deletes the corresponding key columns. This data frame doesn't have a key. If I add a key, then the delete works fine. The code needs to cope with the situation where there is no key.

@lilyclements
Copy link
Contributor

Ah yes, a very good point, and quite a big bug to introduce too! My mistake, I have fixed it here #8416 @rdstern

@rachelkg
Copy link
Contributor

rachelkg commented Jul 7, 2023

@lilyclements and @rdstern
Hello I am having this same issue when using what i think is the most updated version through visual studio. It happens when i try to delete or rename a column.
If this has been fixed in a version that i am not using my apologies.
2023-07-07_14-25-30
2023-07-07_14-25-51

@lilyclements
Copy link
Contributor

@rachelkg yes I noticed this too, this should all be fixed in #8422 and so should be sorted in the most recent version. Can you check and confirm this for you? If it is ok now, I will close this PR :)

@rachelkg
Copy link
Contributor

rachelkg commented Jul 11, 2023

@lilyclements I can now delete columns successfully but when i try to rename I get this error message.
Which is interesting as it looks like it is different from what i got last time.
2023-07-11_10-07-39

@lilyclements
Copy link
Contributor

@rachelkg a very good point, sorry about that. I've now fixed it in #8433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment