Ensured that columns in the Data Grid can be deleted even when there are no key columns #8416
Conversation
There was a problem hiding this comment.
@lilyclements many thanks - this seems to work fine now. @lloyddewit over to you
lloyddewit
changed the title
There was a problem hiding this comment.
@lilyclements Thanks looks good to me. If you can fix the indentation, then I can approve and merge
| if (!is.null(self$get_variables_metadata()$Is_Key)){ | ||
| if (self$get_variables_metadata() %>% dplyr::filter(Name == col_name) %>% dplyr::pull(Is_Key)){ | ||
| active_keys <- self$get_keys() | ||
| keys_to_delete <- which(grepl(curr_col_name, active_keys)) | ||
| keys_to_delete <- which(grepl(col_name, active_keys)) | ||
| keys_to_delete <- purrr::map_chr(.x = keys_to_delete, .f = ~names(active_keys[.x])) | ||
| purrr::map(.x = keys_to_delete, .f = ~self$remove_key(key_name = names(active_keys[.x]))) | ||
| } | ||
| } |
There was a problem hiding this comment.
They should be! I just copied and pasted the file into R and then back into the VB document to autofix the indentations of everything in this file
There was a problem hiding this comment.
@lilyclements I assume that you pasted the whole file into the RStudio editor, and then pasted back into the Visual Studio editor. Unfortunately the GitHub diff interprets this as all 4000+ lines changing (probably because of different white space characters and/or line breaks). This makes it impossible to see the real changes in the PR and has also triggered a merge conflict.
I suggest that you go back to the previous version of the file and fix just the indents mentioned above manually.
Note: you can get the previous version of the file by checking it out from commit 102436e. If you're unsure how to do this, then just let me know.
I'm sorry my comment caused such trouble, I only intended some spaces to be added to the few lines above.
Thanks for your patience.
Fixes #8413
@Vitalis95 can you review this, and then it can be ready for @rdstern to review