Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmented keyboard#5584 #5586

Merged

Conversation

Ivanluv
Copy link
Contributor

@Ivanluv Ivanluv commented Nov 19, 2019

fixes #5584


Private Sub cmdPoints_Click(sender As Object, e As EventArgs) Handles cmdPoints.Click
ucrReceiverForTestColumn.AddToReceiverAtCursorPosition(" points()", 1)
End Sub
Copy link
Contributor

@maxwellfundi maxwellfundi Nov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ivanluv this looks good, Just a point of curiosity, why do we have consistent spaces when you add things to the receiver? is this to make sure there is proper spacing?

if so @dannyparsons can we use chr(32) just to be consistent with what we do for quotes - chr(34)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need the spacings @maxwellfundi .Thank you for noticing this,am correcting this now

@Ivanluv
Copy link
Contributor Author

Ivanluv commented Nov 22, 2019

@rdstern could you look at this

@rdstern
Copy link
Collaborator

rdstern commented Nov 22, 2019

@Ivanluv this is working well now.
One thing was that plot lines should just be plot - both on the key and the command.

Then I suggest this be "parked" until the new main Use Model dialogue has been merged. Then this branch should be updated next.

For reporting the area that I still can't get to work is the plotting, and that is because these are not ggplots. That is a whole new ball game. And the aapc key also doesn't work. But this keyboard would still be useful even without those. So no work is needed on those aspects now.

@Wycklife
Copy link
Contributor

@maxwellfundi I'm looking at it

Copy link
Contributor

@Wycklife Wycklife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxwellfundi This is working well.

@maxwellfundi maxwellfundi merged commit d90e7a8 into IDEMSInternational:master Nov 26, 2019
@rdstern
Copy link
Collaborator

rdstern commented Nov 26, 2019

Pleased this new keyboard has been merged. Note that this is being merged into the "old" Use Model dialogue. There is a new one - pull request #5537 that will update the same dialogue in a different way. I hope there won't be conflicts

@Ivanluv Ivanluv deleted the SegmentedKeyboard#5584 branch February 6, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a segmented keyboard to the Model > Use Model dialogue
4 participants