-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmented keyboard#5584 #5586
Segmented keyboard#5584 #5586
Conversation
updating master
Updating Master
Updating Master
|
||
Private Sub cmdPoints_Click(sender As Object, e As EventArgs) Handles cmdPoints.Click | ||
ucrReceiverForTestColumn.AddToReceiverAtCursorPosition(" points()", 1) | ||
End Sub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ivanluv this looks good, Just a point of curiosity, why do we have consistent spaces when you add things to the receiver? is this to make sure there is proper spacing?
if so @dannyparsons can we use chr(32) just to be consistent with what we do for quotes - chr(34)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need the spacings @maxwellfundi .Thank you for noticing this,am correcting this now
@rdstern could you look at this |
@Ivanluv this is working well now. Then I suggest this be "parked" until the new main Use Model dialogue has been merged. Then this branch should be updated next. For reporting the area that I still can't get to work is the plotting, and that is because these are not ggplots. That is a whole new ball game. And the aapc key also doesn't work. But this keyboard would still be useful even without those. So no work is needed on those aspects now. |
@maxwellfundi I'm looking at it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxwellfundi This is working well.
Pleased this new keyboard has been merged. Note that this is being merged into the "old" Use Model dialogue. There is a new one - pull request #5537 that will update the same dialogue in a different way. I hope there won't be conflicts |
fixes #5584