-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Predict dialogue#5127 #5537
Predict dialogue#5127 #5537
Conversation
…o remember the previous expressions
@africanmathsinitiative/developers can someone review this |
I like the look of the dialogue now. Then I used the Fit Model > Extremes and fevd, adding the argument na.action=na.omit to get the fitted model. Then I used the new Use Model dialogue. a) It looks great now. |
This now all seems to sort of work and looks really good. I took an example datatset from the extRemes package (temperatures). Then used the Model > Model dialogue to fit an extreme value distribution. Then the Model > Use Model dialogue. I am back to having the same problem as before - which went away temporarily! When I try the plot, then the first time the plot appears very quickly and then is gone again. After this I don't get the plot? The print and summary seem to work fine. But when I opt to save, then I no longer get any results in the output window. And I can't find the object I saved. I assume it isn't yet being added to the workbook? |
@rdstern I've made some changes and I think saving this now works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxwellfundi @rdstern has been checking this and it now looks ok to merge once the changes to dlgModelling are removed, those are incorrect and should not belong here anyway.
instat/dlgModelling.vb
Outdated
@@ -255,7 +255,7 @@ Public Class dlgModelling | |||
Private Sub cmdlm_Click(sender As Object, e As EventArgs) Handles cmdlm.Click | |||
Clear() | |||
If ucrChkIncludeArguments.Checked Then | |||
ucrReceiverForTestColumn.AddToReceiverAtCursorPosition("lm(formula = , data, subset, weights, na.action,method = ""qr"", model = TRUE, x = FALSE, y = FALSE, qr = TRUE, singular.ok = TRUE, contrasts = NULL, offset)", 143) | |||
ucrReceiverForTestColumn.AddToReceiverAtCursorPosition("lm(formula = , data, subset, weights, na.action,method = ""qr"", model = TRUE, x = FALSE, y = FALSE, qr = TRUE, singular.ok = TRUE, contrasts = NULL, offset)", 133) | |||
Else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there any changes here? This file is not relevant.
Furthermore when we checked this it was correct before at 143!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ivanluv could you change this minor issue here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volloholic @rdstern This is already resolved now.
…nstat into PredictDialogue#5127
Now that the segmented keyboard is included in the master it would be good if the issue raised by @volloholic could be resolved as well as the conflicts, so this could be merged. |
fixes #5127
adding the show argument check box.
@dannyparsons how are the
iSetCursorBackCharacters
determined in the functionAddToReceiverAtCursorPosition
which is inucrReceiver expression