-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmented keyboard#5584 #5586
Merged
maxwellfundi
merged 7 commits into
IDEMSInternational:master
from
Ivanluv:SegmentedKeyboard#5584
Nov 26, 2019
Merged
Segmented keyboard#5584 #5586
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4403504
Merge pull request #57 from africanmathsinitiative/master
Ivanluv 90652fe
Merge pull request #59 from africanmathsinitiative/master
Ivanluv 2607a5d
Merge pull request #61 from africanmathsinitiative/master
Ivanluv f8fb351
Adding the segmented keyboad to the useModel dialogue
Ivanluv df45ae9
Minor modifications
Ivanluv 8205325
Minor additions
Ivanluv 33524df
changing from plot lines to plot
Ivanluv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ivanluv this looks good, Just a point of curiosity, why do we have consistent spaces when you add things to the receiver? is this to make sure there is proper spacing?
if so @dannyparsons can we use chr(32) just to be consistent with what we do for quotes - chr(34)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need the spacings @maxwellfundi .Thank you for noticing this,am correcting this now