Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room UI Redesign: Fix presence message i18n #3536

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Room UI Redesign: Fix presence message i18n #3536

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7be1f4b
Fix presence message i18n
robertlong Dec 11, 2020
1946d6a
Fix Japanese presence messages
robertlong Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/assets/locales/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,14 +204,14 @@
"autoexit.concurrent_subtitle": "Has empezado una nueva sesión.",
"autoexit.idle_subtitle": "Has estado inactivo por demasiado tiempo.",
"autoexit.cancel": "CANCELAR",
"presence.entered_room": "entró a la sala.",
"presence.entered_lobby": "entró a la antesala.",
"presence.join_lobby": "se unió a la antesala.",
"presence.join_room": "se unió a la sala.",
"presence.leave": "se fue.",
"presence.name_change": "ahora se llama",
"presence.scene_change": "ha cambiado la escena a",
"presence.hub_name_change": "ha cambiado el nombre de la sala a",
"presence.entered_room": "{name} entró a la sala.",
"presence.entered_lobby": "{name} entró a la antesala.",
"presence.join_lobby": "{name} se unió a la antesala.",
"presence.join_room": "{name} se unió a la sala.",
"presence.leave": "{name} se fue.",
"presence.name_change": "{oldName} ahora se llama {newName}",
"presence.scene_change": "{name} ha cambiado la escena a {sceneName}",
"presence.hub_name_change": "{name} ha cambiado el nombre de la sala a {hubName}",
"presence.in_lobby": "Antesala",
"presence.entering": "Entrando a la sala",
"presence.in_room": "En la sala",
Expand Down
16 changes: 8 additions & 8 deletions src/assets/locales/ja.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,14 +204,14 @@
"autoexit.concurrent_subtitle": "別のセッションを開始しました。",
"autoexit.idle_subtitle": "長時間アイドル状態です。",
"autoexit.cancel": "キャンセル",
"presence.entered_room": "部屋に入りました。",
"presence.entered_lobby": "ロビーに入りました。",
"presence.join_lobby": "ロビーに参加しました。",
"presence.join_room": "部屋に参加しました。",
"presence.leave": "退室しました。",
"presence.name_change": "現在は",
"presence.scene_change": "シーンを変更しました",
"presence.hub_name_change": "部屋の名前を変更しました",
"presence.entered_room": "{name} 部屋に入りました。",
"presence.entered_lobby": "{name} ロビーに入りました。",
"presence.join_lobby": "{name} ロビーに参加しました。",
"presence.join_room": "{name} 部屋に参加しました。",
"presence.leave": "{name} 退室しました。",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to suggest

  "presence.entered_room": "{name} が入室しました。",
  "presence.entered_lobby": "{name} がロビーに入りました。",
  "presence.join_lobby": "{name} がロビーに入りました。",
  "presence.join_room": "{name} が入室しました。",
  "presence.leave": "{name} が退室しました。",

"presence.name_change": "名前が {oldName} から {newName} に変更されました",
"presence.scene_change": "シーンが {name} から {sceneName} に変更されました",
"presence.hub_name_change": "部屋名が {name} から {hubName} に変更されました",
"presence.in_lobby": "ロビー",
"presence.entering": "Entering Room",
"presence.in_room": "In Room",
Expand Down
16 changes: 8 additions & 8 deletions src/assets/locales/pt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,14 +204,14 @@
"autoexit.concurrent_subtitle": "Você iniciou uma nova sessão.",
"autoexit.idle_subtitle": "Você está ocioso por muito tempo.",
"autoexit.cancel": "CANCELAR",
"presence.entered_room": "entrou na sala.",
"presence.entered_lobby": "entrou na sala de espera.",
"presence.join_lobby": "entrou na sala de espera.",
"presence.join_room": "entrou na sala.",
"presence.leave": "sair.",
"presence.name_change": "agora é conhecido como",
"presence.scene_change": "mudou o cenário para",
"presence.hub_name_change": "mudou o nome da sala para",
"presence.entered_room": "{name} entrou na sala.",
"presence.entered_lobby": "{name} entrou na sala de espera.",
"presence.join_lobby": "{name} entrou na sala de espera.",
"presence.join_room": "{name} entrou na sala.",
"presence.leave": "{name} sair.",
"presence.name_change": "{oldName} agora é conhecido como {newName}",
"presence.scene_change": "{name} mudou o cenário para {sceneName}",
"presence.hub_name_change": "{name} mudou o nome da sala para {hubName}",
"presence.in_lobby": "Sala de espera",
"presence.entering": "Entrando na sala",
"presence.in_room": "Na sala",
Expand Down
16 changes: 8 additions & 8 deletions src/assets/locales/ru.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,14 +204,14 @@
"autoexit.concurrent_subtitle": "Вы начали новый сеанс.",
"autoexit.idle_subtitle": "Вы были неактивны слишком долго.",
"autoexit.cancel": "ОТМЕНА",
"presence.entered_room": "в комнате.",
"presence.entered_lobby": "в холле.",
"presence.join_lobby": "входит в холл.",
"presence.join_room": "входит в комнату.",
"presence.leave": "покинул(а) место.",
"presence.name_change": "сменил(а) имя на",
"presence.scene_change": "сменил(а) сцену на",
"presence.hub_name_change": "сменил(а) название комнаты на",
"presence.entered_room": "{name} в комнате.",
"presence.entered_lobby": "{name} в холле.",
"presence.join_lobby": "{name} входит в холл.",
"presence.join_room": "{name} входит в комнату.",
"presence.leave": "{name} покинул(а) место.",
"presence.name_change": "{oldName} сменил(а) имя на {newName}",
"presence.scene_change": "{name} сменил(а) сцену на {sceneName}",
"presence.hub_name_change": "{name} сменил(а) название комнаты на {hubName}",
"presence.in_lobby": "Холл",
"presence.entering": "Вход в комнату",
"presence.in_room": "В комнате",
Expand Down
16 changes: 8 additions & 8 deletions src/assets/locales/zh.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,14 +204,14 @@
"autoexit.concurrent_subtitle": "你已经开始了新的会话",
"autoexit.idle_subtitle": "你已经长时间没有进行操作.",
"autoexit.cancel": "取消",
"presence.entered_room": "已进入房间",
"presence.entered_lobby": "已进入休息室",
"presence.join_lobby": "已加入休息室",
"presence.join_room": "已加入房间",
"presence.leave": "离开",
"presence.name_change": "被称为",
"presence.scene_change": "更换场景",
"presence.hub_name_change": "更改房间名字",
"presence.entered_room": "{name} 已进入房间",
"presence.entered_lobby": "{name} 已进入休息室",
"presence.join_lobby": "{name} 已加入休息室",
"presence.join_room": "{name} 已加入房间",
"presence.leave": "{name} 离开",
"presence.name_change": "{oldName} 被称为 {newName}",
"presence.scene_change": "{name} 更换场景 {sceneName}",
"presence.hub_name_change": "{name} 更改房间名字 {hubName}",
"presence.in_lobby": "休息室",
"presence.entering": "正在进入房间",
"presence.in_room": "在房间",
Expand Down