Room UI Redesign: Fix presence message i18n #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirox
reviewed
Dec 11, 2020
src/assets/locales/ja.json
Outdated
| "presence.entered_lobby": "{name} ロビーに入りました。", | ||
| "presence.join_lobby": "{name} ロビーに参加しました。", | ||
| "presence.join_room": "{name} 部屋に参加しました。", | ||
| "presence.leave": "{name} 退室しました。", |
There was a problem hiding this comment.
I'd like to suggest
"presence.entered_room": "{name} が入室しました。",
"presence.entered_lobby": "{name} がロビーに入りました。",
"presence.join_lobby": "{name} がロビーに入りました。",
"presence.join_room": "{name} が入室しました。",
"presence.leave": "{name} が退室しました。",
|
Thanks for the review for the Japanese translations @takahirox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3529
Fixes #3528