docfx 2.70.0 #138314
docfx 2.70.0 #138314
Conversation
github-actions
bot
added
bump-formula-pr
$ HOMEBREW_NO_INSTALL_FROM_API=1 brew install docfx
docfx 2.63.0 is already installed but outdated (so it will be upgraded).
==> Fetching docfx
==> Downloading https://ghcr.io/v2/homebrew/core/docfx/manifests/2.70.0
curl: (22) The requested URL returned error: 404
Error: docfx: Failed to download resource "docfx_bottle_manifest"
Download failed: https://ghcr.io/v2/homebrew/core/docfx/manifests/2.70.0
$ HOMEBREW_NO_INSTALL_FROM_API=1 brew install docfx -v
docfx 2.63.0 is already installed but outdated (so it will be upgraded).
==> Fetching docfx
==> Downloading https://ghcr.io/v2/homebrew/core/docfx/manifests/2.70.0
/usr/bin/env /usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/4.1.3-23-gd2863d0\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 13.5\)\ curl/8.1.2 --header Accept-Language:\ en --fail --retry 3 --header Accept:\ application/vnd.oci.image.index.v1\+json --header Authorization:\ Bearer\ QQ== --remote-time --output /Users/dracula/Library/Caches/Homebrew/downloads/02f6a242d205a524f05e2ba2e731490f09b96852a777b0d73ded532612d51ae8--docfx-2.70.0.bottle_manifest.json.incomplete --location https://ghcr.io/v2/homebrew/core/docfx/manifests/2.70.0
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 70 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (22) The requested URL returned error: 404
Error: docfx: Failed to download resource "docfx_bottle_manifest"
Download failed: https://ghcr.io/v2/homebrew/core/docfx/manifests/2.70.0I don't understand where it's getting the manifest url from. |
you need to do |
|
docfx needs dotnet 8, so it wont be buildable as of now. |
Oh. Yeah I overlooked that, my b.
Works on my end. I don't know if this is an issue only in macOS 11-arm-64. $ HOMEBREW_NO_INSTALL_FROM_API=1 brew install -s docfx
docfx 2.63.0 is already installed but outdated (so it will be upgraded).
==> Fetching docfx
==> Downloading https://github.com/dotnet/docfx/archive/refs/tags/v2.70.0.tar.gz
Already downloaded: /Users/dracula/Library/Caches/Homebrew/downloads/a36ad492f253f3ca2049c1b0c65f7dc6595a8e576c2737e62236a0a52709e930--docfx-2.70.0.tar.gz
==> Upgrading docfx
2.63.0 -> 2.70.0
==> dotnet publish src/docfx --configuration Release --framework net7.0 --output
🍺 /usr/local/Cellar/docfx/2.70.0: 96 files, 34MB, built in 46 seconds
==> Running `brew cleanup docfx`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
Removing: /usr/local/Cellar/docfx/2.63.0... (189 files, 44.3MB)
Removing: /Users/dracula/Library/Caches/Homebrew/docfx--2.63.0... (15.4MB)
$ brew test docfx
==> Testing docfx
==> /usr/local/Cellar/docfx/2.70.0/bin/docfx init -q
$ brew config
HOMEBREW_VERSION: 4.1.3-23-gd2863d0
ORIGIN: https://github.com/Homebrew/brew
HEAD: d2863d05b33177626e66fd4be75e92bcc3f14c99
Last commit: 6 hours ago
Core tap origin: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 9cc0f9120963af86205b2547f385b2be5f48554d
Core tap last commit: 2 hours ago
Core tap branch: bump-docfx-2.70.0
Core tap JSON: 02 Aug 13:33 UTC
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 4
Homebrew Ruby: 2.6.10 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: quad-core 64-bit kabylake
Clang: 14.0.3 build 1403
Git: 2.41.0 => /usr/local/bin/git
Curl: 8.1.2 => /usr/bin/curl
macOS: 13.5-x86_64
CLT: 14.3.1.0.1.1683849156
Xcode: N/A |
this is on the CI |
Do you know why this error might happen only on the CI? |
|
actually you are right, it looks like it only happens on ci. 🤔 |
chenrui333
added
the
CI-no-fail-fast
Yeah, it’s odd. Does it pass locally for you too? |
|
yeah, passed in my local as well, this is my full build log, https://gist.github.com/chenrui333/f5cf7fc2246402d2f081032a50e8791d |
github-actions
bot
added
the
autosquash
|
well, that did not quite work. |
|
@shawnfunke can you help take a look at this build? Thanks! |
|
The reason this fails is because this runs inside of GitHub Actions. In that case it'll add .NET 8 as a additional target framework. Here it uses <ContinuousIntegrationBuild Condition="'$(GITHUB_ACTIONS)' == 'true'">true</ContinuousIntegrationBuild>
<TargetFrameworks>net6.0;net7.0</TargetFrameworks>
<TargetFrameworks Condition=" '$(ContinuousIntegrationBuild)' == 'true' ">$(TargetFrameworks);net8.0</TargetFrameworks> # specify the target framework to only target the currently used version of
# .NET, otherwise additional frameworks will be added due to this running
# inside of GitHub Actions, for details see:
# https://github.com/dotnet/docfx/blob/fc7deda119eebd830a2d37882698dcbaedaec24b/Directory.Build.props#L3-L5
args = %W[
--configuration Release
--framework net#{dotnet.version.major_minor}
--output #{libexec}
--runtime #{os}-#{arch}
--no-self-contained
-p:Version=#{version}
-p:TargetFrameworks=net#{dotnet.version.major_minor}
] |
|
ah, I see, that makes sense. |
specify TargetFramework Signed-off-by: Rui Chen <[email protected]> docfx: specify TargetFrameworks Signed-off-by: Rui Chen <[email protected]>
chenrui333
force-pushed
the
bump-docfx-2.70.0
branch
from
a332e5b to
1c49d34
Compare
|
Thanks @shawnfunke! |
github-actions
bot
removed
the
autosquash
|
@chenrui333 no problem, feel free to ask at anytime. I wonder if |
looks like it is indeed used pretty extensively by dotnet community, https://grep.app/search?q=GITHUB_ACTIONS&filter[path.pattern][0]=Directory.Build.props (but we dont have many dotnet formulae yet though), for now, I would say just override via dotnet build option. Once we have more, we can update test-bot for this. |
That seems very odd. Upstream should provide a better toggle than |
Usually the The idea behind setting |
|
My suggestion would be the opposite: we should not pass through that variable through to builds implicitly. |
There's already another workaround being used for this build that will do the job for now. Sure the other way around works as well. I am not sure where to start with making this change as I'm not to familiar with the code base of Brew itself. I would guess that it would be here: |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
the build option with |
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
🎉 New Features
docfx servecommand by @filzrev in Add open browser options to docfx-serve command dotnet/docfx#8934Docfx.Appby @dpvreony in Add PDF generation ability to Microsoft.DocAsCode.App dotnet/docfx#8939🐞 Bug Fixes
🔧 Engineering
📄 Documentation
New Contributors
Full Changelog: dotnet/docfx@v2.67.5...v2.70.0