Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: see/seealso tag copies href when a child node exist #8974

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: see/seealso tag copies href when a child node exist #8974

merged 1 commit into from
Jul 17, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Jul 17, 2023

fixes #8965

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (a3c8409) 76.86% compared to head (2ef47c8) 76.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8974      +/-   ##
==========================================
- Coverage   76.86%   76.85%   -0.02%     
==========================================
  Files         601      601              
  Lines       24968    24968              
==========================================
- Hits        19191    19188       -3     
- Misses       5777     5780       +3     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih merged commit fc5502d into main Jul 17, 2023
@yufeih yufeih deleted the 8965 branch July 17, 2023 03:46
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
fix: see/seealso tag checks descendant inner text

Co-authored-by: Yufei Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] XmlCommentTransform copies see/@href to content even if a child element exists
1 participant