Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warning NU1701 #8904

Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix warning NU1701 #8904

merged 1 commit into from
Jun 30, 2023

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Jun 26, 2023

Fix warnings occurred when following conditions met.

  • Using Microsoft.DocAsCode.App NuGet package
  • TargetFramework is net6.0.

Warnings Messages

Warning NU1701 Package 'Microsoft.Build 17.6.3' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net6.0'. This package may not be fully compatible with your project.

Warning NU1701 Package 'Microsoft.IO.Redist 6.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net6.0'. This package may not be fully compatible with your project.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (12f3998) 77.00% compared to head (4b2104e) 76.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8904      +/-   ##
==========================================
- Coverage   77.00%   76.99%   -0.01%     
==========================================
  Files         605      605              
  Lines       25036    25036              
==========================================
- Hits        19278    19277       -1     
- Misses       5758     5759       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @filzrev

@yufeih yufeih merged commit f689ba1 into dotnet:main Jun 30, 2023
@yufeih yufeih added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Jun 30, 2023
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants